Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delay php-fpm service restart upon configuration update #365

Merged

Conversation

igolman
Copy link
Contributor

@igolman igolman commented Nov 6, 2024

Description

This resolves unneeded subsequent restarts of phpX.Y-fpm service upon FPM pool configuration update.
If more than 5 FPM pools are affected of a configuration change, systemd will fail to restart the service with following error:

php8.1-fpm.service: Start request repeated too quickly.
php8.1-fpm.service: Failed with result 'start-limit-hit'.
Failed to start The PHP 8.1 FastCGI Process Manager.

Although according to chef resource documentation the default value for the :timer is :delayed, it seems not to be the case and should be explicitly set.
This behavior may be observed at the github's regressions tests

Issues Resolved

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@igolman igolman requested a review from a team as a code owner November 6, 2024 13:37
@damacus damacus self-assigned this Nov 7, 2024
@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label Nov 7, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@damacus
Copy link
Member

damacus commented Nov 7, 2024

Nice simple change. Thanks for this.

If there are any unintended consequences like ordering. Let us know, and maybe we can make this configurable

@damacus damacus merged commit c7e3065 into sous-chefs:main Nov 7, 2024
42 of 44 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 10.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants