Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: broker can initialize connector endpoint filters from query params #683

Merged
merged 7 commits into from
Feb 28, 2024
Merged

feat: broker can initialize connector endpoint filters from query params #683

merged 7 commits into from
Feb 28, 2024

Conversation

kulgg
Copy link
Collaborator

@kulgg kulgg commented Feb 28, 2024 •
edited
Loading

What issues does this PR close?

closes sovity/authority-portal#841

Checklist
Preview Give feedback

@kulgg kulgg self-assigned this Feb 28, 2024
@kulgg kulgg requested a review from richardtreier February 28, 2024 11:16
@kulgg kulgg enabled auto-merge (squash) February 28, 2024 11:16
richardtreier
richardtreier requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in total i believe you coped around something you needed in the state management, i think we shouldn't cope here, but just adjust the state management if necessary

CHANGELOG.md Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/catalog-page/catalog-page.component.ts Outdated Show resolved Hide resolved
src/app/routes/broker-ui/catalog-page/state/catalog-page-state.ts Outdated Show resolved Hide resolved
richardtreier
richardtreier approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulgg kulgg merged commit 3a6e6f3 into main Feb 28, 2024
13 checks passed
@kulgg kulgg deleted the broker-query-params-endpoints branch February 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

Assignees

@kulgg kulgg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulgg @richardtreier