Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use CreateDataOffer API #825

Merged
merged 28 commits into from
Sep 20, 2024
Merged

feat: use CreateDataOffer API #825

merged 28 commits into from
Sep 20, 2024

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Sep 13, 2024 •
edited
Loading

What issues does this PR close?
closes #1373
closes #841 Use new CreateDataOffer API

Checklist
Preview Give feedback

@illfixit illfixit marked this pull request as ready for review September 13, 2024 11:04
@illfixit illfixit enabled auto-merge (squash) September 19, 2024 14:02
richardtreier
richardtreier approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illfixit illfixit merged commit 6f5eaa3 into main Sep 20, 2024
13 checks passed
@illfixit illfixit deleted the 1373-gap-create-data-offer-endpoint branch September 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new CreateDataOffer API
2 participants
@illfixit @richardtreier