Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Christmas items are appearing on scavs during Halloween event #777

Open
refringe opened this issue Nov 24, 2024 · 7 comments
Open

Christmas items are appearing on scavs during Halloween event #777

refringe opened this issue Nov 24, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@refringe
Copy link
Contributor

Need to investigate and see if this is occurring


Originally written by chomp

@refringe refringe added the bug Something isn't working label Nov 24, 2024
@refringe
Copy link
Contributor Author

I can confirm that I found a red and (at a later time) a white Christmas ornament on scavs durring the Halloween event. It was, however, on a heavily modified installation.

I'll see if I can reproduce later tonight on a clean vanilla install to get you some logs.


Originally written by Refringe

@refringe
Copy link
Contributor Author

Found twice Christmas tree ornament (Silver) "5df8a72c86f77412640e2e83" in PMC's backpacks. 3.7.4 hotfix.


Originally written by Barlog_M

@refringe
Copy link
Contributor Author

That would be because the Christmas even has started


Originally written by DrakiaXYZ

@refringe
Copy link
Contributor Author

This code does not disable Christmas event? It works for Halloween

    disableSeasonalEvents(container: DependencyContainer): undefined {
        const configServer = container.resolve<ConfigServer>("ConfigServer");
        const seasonalEventConfig =
            configServer.getConfig<ISeasonalEventConfig>(
                ConfigTypes.SEASONAL_EVENT
            );
        seasonalEventConfig.enableSeasonalEventDetection = false;
    }

Originally written by Barlog_M

@refringe
Copy link
Contributor Author

Looking at the server code, no idea if that specific setting is meant to disable the loot for events or not.

However this task is about Christmas items showing up during the wrong event, nothing in here mentions disabling seasonal events.


Originally written by DrakiaXYZ

@refringe
Copy link
Contributor Author

Then sorry. I thought it may be connected.


Originally written by Barlog_M

@refringe
Copy link
Contributor Author

image

Can confirm still does happen with just halloween enabled but for PMCs haven't seen a scav with a chrismas ball yet.


Attachments


Originally written by Kaeno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants