Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Flea player offer selling code needs to be refactored #946

Open
refringe opened this issue Nov 25, 2024 · 2 comments
Open

[Server] Flea player offer selling code needs to be refactored #946

refringe opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request help-wanted Extra attention is needed

Comments

@refringe
Copy link
Contributor

The current implementation has a number of drawbacks and a new approach is required to better simulate selling on live.

Relevant code:

RagfairController.addPlayerOffer()
RagfairOfferHelper.processOffersOnProfile()

Problems:

  • Low maintainability
  • Difficult to adjust
  • Offers well below average take a long time to sell

Originally written by chomp

@refringe refringe added enhancement New feature or request help-wanted Extra attention is needed labels Nov 25, 2024
@refringe
Copy link
Contributor Author

Offers well below average take a long time to sell

Looking though the code I think RagfairSellHelper.rollForSale() would be the place to add logic that considers the sell price.


Originally written by snekcode

@refringe
Copy link
Contributor Author

This has been somewhat alleviated by having the flea offer check time reduced to 8 secs when out of raid + the adjustments made to the sell curve


Originally written by chomp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted Extra attention is needed
Projects
Status: Backlog
Development

No branches or pull requests

2 participants