Make EngineVersion nullable

FUCK ignore that previous commit, I forgot to push this before merging the PR.
space-wizards · Jul 14, 2024 · aa6c64a · aa6c64a
1 parent 15f4512
commit aa6c64a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/Robust.Cdn/Controllers/ForkBuildPageController.cs b/Robust.Cdn/Controllers/ForkBuildPageController.cs
@@ -78,7 +78,7 @@ public sealed class Version
     {
         public required string Name;
         public required DateTime PublishedTime;
-        public required string EngineVersion;
+        public required string? EngineVersion;
         public required VersionServer[] Servers;
     }
 
@@ -94,6 +94,6 @@ private sealed class DbVersion
         public required int Id { get; set; }
         public required string Name { get; set; }
         public required DateTime PublishedTime { get; set; }
-        public required string EngineVersion { get; set; }
+        public required string? EngineVersion { get; set; }
     }
 }
diff --git a/Robust.Cdn/ManifestMigrations/Script0001_Init.sql b/Robust.Cdn/ManifestMigrations/Script0001_Init.sql
@@ -28,7 +28,8 @@ CREATE TABLE ForkVersion(
     ClientSha256 BLOB NOT NULL,
 
     -- Not strictly necessary, but I'll save it here anyways.
-    EngineVersion TEXT NOT NULL,
+    -- NULL for old imported builds before this value was tracked.
+    EngineVersion TEXT NULL,
 
     -- Whether this version is available for servers to download.
     -- This is updated after CDN content ingestion finishes.

diff --git a/Robust.Cdn/Views/ForkBuildPage/Index.cshtml b/Robust.Cdn/Views/ForkBuildPage/Index.cshtml
@@ -33,8 +33,11 @@
                 <dd><span class="versionNumber">@version.Name</span></dd>
                 <dt>Date:</dt>
                 <dd><time datetime="@version.PublishedTime.ToString("O")">@version.PublishedTime.ToString("f") UTC</time></dd>
-                <dt>Engine Version:</dt>
-                <dd><span class="versionNumber">@version.EngineVersion</span></dd>
+                @if (version.EngineVersion is { } engineVersion)
+                {
+                    <dt>Engine Version:</dt>
+                    <dd><span class="versionNumber">@engineVersion</span></dd>
+                }
             </dl>
             <h3>Download</h3>
             <ul class="build-download-list">