a

space-wizards · Mar 27, 2024 · e802281 · e802281
1 parent 5e813a7
commit e802281
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/Content.Server/Ghost/Roles/Components/GhostRoleComponent.cs b/Content.Server/Ghost/Roles/Components/GhostRoleComponent.cs
@@ -11,8 +11,7 @@ public sealed partial class GhostRoleComponent : Component
 
         [DataField("description")] private string _roleDescription = "Unknown";
 
-        [Access(typeof(GhostRoleSystem), Other = AccessPermissions.None)]
-        [DataField("rules")] public string _rules = "ghost-role-component-default-rules";
+        [DataField("rules")] private string _roleRules = "ghost-role-component-default-rules";
 
         [DataField("requirements")]
         public HashSet<JobRequirement>? Requirements;
@@ -58,7 +57,15 @@ public string RoleDescription
 
         [ViewVariables(VVAccess.ReadWrite)]
         [Access(typeof(GhostRoleSystem), Other = AccessPermissions.ReadWriteExecute)] // FIXME Friends
-        public string RoleRules => Loc.GetString(_rules);
+        public string RoleRules
+        {
+            get => Loc.GetString(_roleRules);
+            set
+            {
+                _roleRules = value;
+                EntitySystem.Get<GhostRoleSystem>().UpdateAllEui();
+            }
+        }
 
         [DataField("allowSpeech")]
         [ViewVariables(VVAccess.ReadWrite)]

diff --git a/Content.Server/Ghost/Roles/GhostRoleSystem.cs b/Content.Server/Ghost/Roles/GhostRoleSystem.cs
@@ -324,20 +324,11 @@ private void OnMapInit(Entity<GhostRoleComponent> ent, ref MapInitEvent args)
                 RemCompDeferred<GhostRoleComponent>(ent);
         }
 
-        private void OnStartup(Entity<GhostRoleComponent> ent, ComponentStartup args)
+        private void OnStartup(Entity<GhostRoleComponent> ent, ref ComponentStartup args)
         {
             RegisterGhostRole(ent);
         }
 
-        public void UpdateRules(Entity<GhostRoleComponent?> ent, string rules)
-        {
-            if (!Resolve(ent, ref ent.Comp))
-                return;
-
-            ent.Comp._rules = rules;
-            UpdateAllEui();
-        }
-
         private void OnShutdown(Entity<GhostRoleComponent> role, ref ComponentShutdown args)
         {
             UnregisterGhostRole(role);