Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rooting through plants spams rooting notification and sound effect #26853

Closed
Terraspark4941 opened this issue Apr 9, 2024 · 1 comment · Fixed by #26901
Closed

Rooting through plants spams rooting notification and sound effect #26853

Terraspark4941 opened this issue Apr 9, 2024 · 1 comment · Fixed by #26901
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Bug Something is not working correctly.

Comments

@Terraspark4941
Copy link
Contributor

Terraspark4941 commented Apr 9, 2024 •
edited
Loading

Description

Title says it all

Reproduction

  1. Join map
  2. Root through plant
  3. Loss

Screenshots

image

Additional context

Seems to be related to the shield popup spam (similar phenomenon)
@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Apr 9, 2024
@Tayrtahn
Copy link
Member

Tayrtahn commented Apr 9, 2024

Looks like #22133 moved PottedPlantHideSystem from Server to Shared but didn't adjust the behavior to account for prediction.

Simple enough to fix:

  • The call to _popup.PopupEntity should be changed to _popup.PopupPredicted (or PopupClient depending on whether other players are intended to see the message).
  • The call to _audio.PlayPvs should be changed to _audio.PlayPredicted.

Both will need to have the user's uid passed as an additional parameter, which means the method signature of Rustle will need to be modified.

@Tayrtahn Tayrtahn added Issue: Bug Something is not working correctly. Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. and removed Status: Untriaged Somebody go through and give this appropriate labels labels Apr 9, 2024
@Tayrtahn Tayrtahn mentioned this issue Apr 12, 2024
Merged
1 task
@JIPDawg JIPDawg mentioned this issue May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Bug Something is not working correctly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix potted plant popup/sfx spam Tayrtahn/space-station-14
2 participants
@Tayrtahn @Terraspark4941