Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The slippery plant mutation affects the plantholder instead of the produce #32529

Closed
slarticodefast opened this issue Sep 29, 2024 · 3 comments
Closed
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Bug Something is not working correctly.

Comments

@slarticodefast
Copy link
Member

Description

It used to be the harvested produce that was affected by the mutation.
Must have happened unintentionally in #31163
Also the slippery effect stays even if the plant is removed from the plantholder.

Reproduction

  • Plant something in the plantholder.
  • Add mutagen to the plantholder until you get the slippery mutation.
  • The plantholder is now slippery.
  • Remove the plant.
  • The plantholder still has the SlipperyComponent.

Screenshots
Screenshot (297)

@drakewill-CRL

@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Sep 29, 2024
@slarticodefast slarticodefast added Issue: Bug Something is not working correctly. Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. and removed Status: Untriaged Somebody go through and give this appropriate labels labels Sep 29, 2024
@slarticodefast
Copy link
Member Author

The same thing seems to happen with the bioluminiscent mutation: The plantholder is affected as well and keeps glowing after the plant is removed.
grafik

@drakewill-CRL
Copy link
Contributor

Right now, I don't think theres a way to undo EntityEffects directly, and they get applied to the tray because the tray is the plant code-wise.

The correct fix for this is to implement #31941, which will apply the effect to the plant and it will go away as part of the plant's removal as expected.

@slarticodefast
Copy link
Member Author

slarticodefast commented Sep 29, 2024

Yeah, but they should be only applied to the produce in the first place, not to the tray.
At least that was how it worked before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Bug Something is not working correctly.
Projects
None yet
Development

No branches or pull requests

2 participants