Automated whitelists #23985

Simyon264 · 2024-01-12T20:52:53Z

About the PR

This PR adds automatic whitelists based on conditions defined in a prototype.

Why / Balance

Resolves #19606.

Technical details

This PR adds a blacklist table to the DB and the coresponding commands for managing the blacklist.
I also added a new prototype PlayerConnectionWhitelist which is used to define whitelists. That prototype contains an Array of WhitelistCondition conditions. Every WhitelistCondition contains 2 DataFields and a Function to check if the player is allowed to connect. The 2 DataFields are the following:
BreakIfConditionSuccess: If the condition passes, the next conditions will not be checked and the player will be able to connect.
BreakIfConditionFail: If the condition fails, the player will be denied and the next conditions will not be checked.

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

This removes some CVars related for whitelists, the legacy whitelists are used by default when whitelist.enabled is set to true. Use whitelist.prototypeList to define which whitelists should be used. Currently implemented whitelists are: mrpWhitelist and basicWhitelist.

Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist

…eck fails

Default whitelist is now the "legacy" whitelist.

Chief-Engineer

Overall, it looks like it would work for WizDen's needs, but changes could be made to improve readability of the prototype, and to make the system more flexible, potentially allowing it to be easier to use for other things in the future.

Adding support for playtime based ranges for the note condition is probably the thing that'd have the biggest impact on the effectiveness of the system for WizDen

Chief-Engineer · 2024-01-14T05:25:34Z

Content.Server/Connection/Whitelist/WhitelistPrototype.cs

This is a terminology nitpick, but to keep things flexible, I'd avoid using the term whitelist/blacklist. It's all just conditions or rules that contribute to an overall blacklist or whitelist system, using terminology that doesn't describe any of the conditions as a whitelist or blacklist can encourage people who make changes in the future to keep the design flexible.

It's not the "Minimum number of players required for this whitelist to be active", it's the "Minimum number of players required for this condition to match", because if the condition can be used flexibly enough, then it can be used as a whitelist or a blacklist

Content.Server/Connection/Whitelist/WhitelistCondition.cs

Content.Server/Connection/Whitelist/Conditions/ConditionNotes.cs

Content.Server.Database/Model.cs

Content.Server/Connection/Whitelist/Conditions/ConditionNotes.cs

metalgearsloth · 2024-02-01T11:33:30Z

@Simyon264 you working on this famalams.

Simyon264 · 2024-02-01T18:26:52Z

Yes. I am still working on it.

github-actions · 2024-02-20T09:16:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Chief-Engineer

Sorry for not catching this earlier. It seems like there are some quirks with the manual whitelist/blacklist conditions.

It's very possible that I'm missing something, partly because I'm just looking at the changes on GitHub, but it looks like the manual whitelist/blacklist conditions have opposite behavior based on someone's status in the list. I understand why this would have been done, but I think both of these should act as a "is the person on the list" check instead for two reasons:

A long term goal would be to allow arbitrary lists to be made so that servers can create as many manual lists as they want for whatever purpose they have, potentially even using those lists for other things unrelated to connections. Having conditions work as being list membership now will prevent having to make changes in the future that either break YAML configs or require workarounds.
I think it makes the rules clearer in the YAML. ConditionManualBlacklist allow seems weird. It might also help to append Membership to the conditions, but that'd increase the name length quite a bit.

Resources/Prototypes/whitelists.yml

Resources/Prototypes/wizardsDenWhitelists.yml

Simyon264 · 2024-07-06T10:24:20Z

A long term goal would be to allow arbitrary lists to be made so that servers can create as many manual lists as they want for whatever purpose they have, potentially even using those lists for other things unrelated to connections. Having conditions work as being list membership now will prevent having to make changes in the future that either break YAML configs or require workarounds.

Something like this? @Chief-Engineer

  - !type:ConditionMembership
    list: whitelist # Which list the player needs to be a part of
    requiredMembershipTime: 120 # Must be a member for 2 hours
    action: Allow
  - !type:ConditionAlwaysMatch
    action: Deny # Not a member, deny connection

Chief-Engineer · 2024-07-08T06:38:22Z

A long term goal would be to allow arbitrary lists to be made so that servers can create as many manual lists as they want for whatever purpose they have, potentially even using those lists for other things unrelated to connections. Having conditions work as being list membership now will prevent having to make changes in the future that either break YAML configs or require workarounds.

Something like this? @Chief-Engineer
  - !type:ConditionMembership
    list: whitelist # Which list the player needs to be a part of
    requiredMembershipTime: 120 # Must be a member for 2 hours
    action: Allow
  - !type:ConditionAlwaysMatch
    action: Deny # Not a member, deny connection

Yes, except I'm not sure that requiredMembershipTime would be too useful unless the lists were automatically generated

github-actions · 2024-07-11T01:10:38Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-08-09T06:23:42Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

PJB3005

I'll fix these issues myself real quick.

PJB3005 · 2024-08-27T15:19:39Z

Content.Server/Connection/ConnectionManager.Whitelist.cs

+        Dictionary<NetUserId, List<IAdminRemarksRecord>> cacheRemarks = new();
+        Dictionary<NetUserId, List<PlayTime>> cachePlaytime = new();


Why are you storing this keyed on user ID if this function only runs for a single user at once?

PJB3005 · 2024-08-27T15:22:16Z

Content.Server/Connection/ConnectionManager.Whitelist.cs

+        return await _db.GetBlacklistStatusAsync(data.UserId);
+    }
+
+    private async Task<bool> CheckConditionNotesDateRange(ConditionNotesDateRange conditionNotes, List<IAdminRemarksRecord> remarks)


These don't need to be async

PJB3005 · 2024-08-27T15:22:55Z

Content.Server/Connection/ConnectionManager.cs

+            if (bans.Count > 0)
+            {
+                var firstBan = bans[0];
+                var message = firstBan.FormatBanMessage(_cfg, _loc);
+                return (ConnectionDenyReason.Ban, message, bans);
+            }


Screwed up merge xd

@deltanedas

* Update Credits (space-wizards#31409) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <dimastra@users.noreply.github.com> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <JIPDawg93@gmail.com> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: Mervill <mervills.email@gmail.com> Co-authored-by: PursuitInAshes <pursuitinashes@gmail.com> Co-authored-by: eoineoineoin <github@eoinrul.es> Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: themias <89101928+themias@users.noreply.github.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com> Co-authored-by: PopGamer46 <yt1popgamer@gmail.com> Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com> Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com> Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com> Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com> Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: QueerNB <176353696+QueerNB@users.noreply.github.com> Co-authored-by: 12rabbits <53499656+12rabbits@users.noreply.github.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> Co-authored-by: Dimastra <65184747+Dimastra@users.noreply.github.com> Co-authored-by: Dimastra <dimastra@users.noreply.github.com> Co-authored-by: JIPDawg <51352440+JIPDawg@users.noreply.github.com> Co-authored-by: JIPDawg <JIPDawg93@gmail.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com> Co-authored-by: stellar-novas <stellar_novas@riseup.net> Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>

* Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * meta update (space-wizards#31423) * Automatic changelog update * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Automatic changelog update * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * Automatic changelog update * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Automatic changelog update * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31502) * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31535) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * fix12312314234235 --------- Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com> Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com> Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com> Co-authored-by: Mervill <mervills.email@gmail.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com> Co-authored-by: JustCone <141039037+JustCone14@users.noreply.github.com> Co-authored-by: lunarcomets <140772713+lunarcomets@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: themias <89101928+themias@users.noreply.github.com> Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>

@deltanedas

* Air alarms check sensors upon power returning * Update Credits (space-wizards#31409) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <dimastra@users.noreply.github.com> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <JIPDawg93@gmail.com> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Make nukie plushie a non-contraband item (space-wizards#31516) Make nukie plushies a non-contraband item * Automatic changelog update * fix uncapitalized "S" in Salvage Specialist (space-wizards#31529) "Salvage specialist" to "Salvage Specialist"; all is right with the world * Make AKMS security restricted (space-wizards#31519) * Automatic changelog update * bagel update (space-wizards#31535) * Update submodule to 231.1.0 (space-wizards#31536) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. # Conflicts: # Content.Client/Silicons/StationAi/StationAiOverlay.cs * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Storage BUI bandaid (space-wizards#31506) grug storageuicontroller * Fix puddle context menu (space-wizards#31555) * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Update ClothingSpeedModifierSystem.cs (space-wizards#29994) * TryGetContainerContainer * Math * Changed AddMarkup to AddMarkupOrThrow * Better math * engine version * engine version * Add black suspenders (space-wizards#29055) * Black suspenders * fix * fix linter * Automatic changelog update * recolor riot helmet (space-wizards#31530) * recolor riot helmet resolves space-wizards#31256 match riot helmet to default security helmet * further color tweaks for consistency; update meta.json Tweaked equipped sprites to more closely match the security helmet. * Automatic changelog update * added wide-spectrum anomaly locator to anomaly cyborg module (space-wizards#31427) added wide-spectrum anomaly locator to anomaly borg module * Automatic changelog update * Add Robust.Xaml.csproj to the solution (space-wizards#31573) * add construction for carp statue (space-wizards#31261) * separate eyes and teeth * make it buildable and make fixture less abusable * norot --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Fixes shuttles not being able to FTL onto/near station (space-wizards#31569) fixes FTL * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Bagel - LV cable wasn't connected (space-wizards#31591) fixes a missing wire * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * bagel update (space-wizards#31605) * Sec Webbing Icon Resprite and Rename (space-wizards#29599) * Sec Webbing Icon Resprite and Rename * Renamed To Security Carrier * Cherry (space-wizards#28962) * Add files via upload * Update produce.yml * Update produce.yml * Update seeds.yml * Update flavor-profiles.ftl * Update flavors.yml * Update meal_recipes.yml * Update food_produce.yml * Update meta.json * Update seeds.yml * Update botany.yml * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Update produce.yml * Update produce.yml * Update produce.yml * Update food_produce.yml * Update food_produce.yml * Update produce.yml * Apply suggestions from code review Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * Update seeds.yml * Update juice.yml * Update juice.ftl * Update seeds.ftl * Update seeds.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_vending.yml * Update cargo_vending.yml * Update seeds.yml * Update seeds.yml * Update meta.json * Update produce.yml * Cherry Tree * Alphabetical order * Update food_produce.yml * Update food-sequence.ftl * Update food-sequence.ftl * Update produce.yml * Update produce.yml * Update food-sequence.ftl --------- Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * Automatic changelog update * Add Command Glasses (space-wizards#30447) * Initial commit * Removed wanted and mindshield status display * Updated glasses visuals & contraband status * Added Command Hud * Changed name to administration glasses/hud * Automatic changelog update * Added plastitanium walls and windows (space-wizards#31178) * added plastitanium walls and windows * Changed crack sprite on diagonal window from square to diagonal * Automatic changelog update * Make railings render over tables (space-wizards#31589) Make rails render over tables * Automatic changelog update * Update submodule to 232.0.0 (space-wizards#31616) * Automatic changelog update * Fixup playerspawn stuff (space-wizards#31546) * Fixup playerspawn stuff - Also removed arrivals forcing, this should just turn containerspawnpoint off. * fix this one * test fix * really fix * strange pill tweaks (space-wizards#30524) * fix randomfill logic * Revert "fix randomfill logic" This reverts commit 7cd73c0. * change strange pill weights * proposed balance changes * Automatic changelog update * Fix openable visuals (space-wizards#31484) First commit * reduce lathe recipe copy pasta (space-wizards#31515) * add inheritance to lathe recipes and make result an override * add GetResult method to lathe system * make other parts of the code use GetResult * clean up the stock parts yml * remove unused apu boards from dynamic recipes * make inverse dictionary public so test doesnt have to copy paste * revert result override stuff --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * cog update (space-wizards#31631) * cog update * woopsie, fixed that * fix cherries * fix cherries 2 electric boogaloo * fix maps --------- Co-authored-by: osjarw <oskariwjarvinen@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: Mervill <mervills.email@gmail.com> Co-authored-by: PursuitInAshes <pursuitinashes@gmail.com> Co-authored-by: eoineoineoin <github@eoinrul.es> Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: themias <89101928+themias@users.noreply.github.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com> Co-authored-by: PopGamer46 <yt1popgamer@gmail.com> Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com> Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com> Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com> Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com> Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: QueerNB <176353696+QueerNB@users.noreply.github.com> Co-authored-by: 12rabbits <53499656+12rabbits@users.noreply.github.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> Co-authored-by: Dimastra <65184747+Dimastra@users.noreply.github.com> Co-authored-by: Dimastra <dimastra@users.noreply.github.com> Co-authored-by: JIPDawg <51352440+JIPDawg@users.noreply.github.com> Co-authored-by: JIPDawg <JIPDawg93@gmail.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com> Co-authored-by: stellar-novas <stellar_novas@riseup.net> Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com> Co-authored-by: saintmuntzer <47153094+saintmuntzer@users.noreply.github.com> Co-authored-by: JustCone <141039037+JustCone14@users.noreply.github.com> Co-authored-by: lunarcomets <140772713+lunarcomets@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: coolboy911 <85909253+coolboy911@users.noreply.github.com> Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com> Co-authored-by: DieselMohawk <gavin.drinka@gmail.com> Co-authored-by: RumiTiger <154005209+RumiTiger@users.noreply.github.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com> Co-authored-by: Unisol <1929445+Unisol@users.noreply.github.com> Co-authored-by: Partmedia <kevinz5000@gmail.com> Co-authored-by: MisterMecky <mrmecky@hotmail.com>

@deltanedas

* Air alarms check sensors upon power returning * Update Credits (space-wizards#31409) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <dimastra@users.noreply.github.com> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <JIPDawg93@gmail.com> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Make nukie plushie a non-contraband item (space-wizards#31516) Make nukie plushies a non-contraband item * Automatic changelog update * fix uncapitalized "S" in Salvage Specialist (space-wizards#31529) "Salvage specialist" to "Salvage Specialist"; all is right with the world * Make AKMS security restricted (space-wizards#31519) * Automatic changelog update * bagel update (space-wizards#31535) * Update submodule to 231.1.0 (space-wizards#31536) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. # Conflicts: # Content.Client/Silicons/StationAi/StationAiOverlay.cs * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Storage BUI bandaid (space-wizards#31506) grug storageuicontroller * Fix puddle context menu (space-wizards#31555) * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Update ClothingSpeedModifierSystem.cs (space-wizards#29994) * TryGetContainerContainer * Math * Changed AddMarkup to AddMarkupOrThrow * Better math * engine version * engine version * Add black suspenders (space-wizards#29055) * Black suspenders * fix * fix linter * Automatic changelog update * recolor riot helmet (space-wizards#31530) * recolor riot helmet resolves space-wizards#31256 match riot helmet to default security helmet * further color tweaks for consistency; update meta.json Tweaked equipped sprites to more closely match the security helmet. * Automatic changelog update * added wide-spectrum anomaly locator to anomaly cyborg module (space-wizards#31427) added wide-spectrum anomaly locator to anomaly borg module * Automatic changelog update * Add Robust.Xaml.csproj to the solution (space-wizards#31573) * add construction for carp statue (space-wizards#31261) * separate eyes and teeth * make it buildable and make fixture less abusable * norot --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Fixes shuttles not being able to FTL onto/near station (space-wizards#31569) fixes FTL * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Bagel - LV cable wasn't connected (space-wizards#31591) fixes a missing wire * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * bagel update (space-wizards#31605) * Sec Webbing Icon Resprite and Rename (space-wizards#29599) * Sec Webbing Icon Resprite and Rename * Renamed To Security Carrier * Cherry (space-wizards#28962) * Add files via upload * Update produce.yml * Update produce.yml * Update seeds.yml * Update flavor-profiles.ftl * Update flavors.yml * Update meal_recipes.yml * Update food_produce.yml * Update meta.json * Update seeds.yml * Update botany.yml * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Update produce.yml * Update produce.yml * Update produce.yml * Update food_produce.yml * Update food_produce.yml * Update produce.yml * Apply suggestions from code review Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * Update seeds.yml * Update juice.yml * Update juice.ftl * Update seeds.ftl * Update seeds.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_vending.yml * Update cargo_vending.yml * Update seeds.yml * Update seeds.yml * Update meta.json * Update produce.yml * Cherry Tree * Alphabetical order * Update food_produce.yml * Update food-sequence.ftl * Update food-sequence.ftl * Update produce.yml * Update produce.yml * Update food-sequence.ftl --------- Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * Automatic changelog update * Add Command Glasses (space-wizards#30447) * Initial commit * Removed wanted and mindshield status display * Updated glasses visuals & contraband status * Added Command Hud * Changed name to administration glasses/hud * Automatic changelog update * Added plastitanium walls and windows (space-wizards#31178) * added plastitanium walls and windows * Changed crack sprite on diagonal window from square to diagonal * Automatic changelog update * Make railings render over tables (space-wizards#31589) Make rails render over tables * Automatic changelog update * Update submodule to 232.0.0 (space-wizards#31616) * Automatic changelog update * Fixup playerspawn stuff (space-wizards#31546) * Fixup playerspawn stuff - Also removed arrivals forcing, this should just turn containerspawnpoint off. * fix this one * test fix * really fix * strange pill tweaks (space-wizards#30524) * fix randomfill logic * Revert "fix randomfill logic" This reverts commit 7cd73c0. * change strange pill weights * proposed balance changes * Automatic changelog update * Fix openable visuals (space-wizards#31484) First commit * reduce lathe recipe copy pasta (space-wizards#31515) * add inheritance to lathe recipes and make result an override * add GetResult method to lathe system * make other parts of the code use GetResult * clean up the stock parts yml * remove unused apu boards from dynamic recipes * make inverse dictionary public so test doesnt have to copy paste * revert result override stuff --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * cog update (space-wizards#31631) * cog update * woopsie, fixed that * Fix energy shield visuals (space-wizards#31619) fix energy shield visuals * Automatic changelog update * Added Armband Onto Back Sprite of Security Jumpsuit (space-wizards#31635) * Fixed Minor Mistake * Fixed the NEW sprite and added Jumpskirt Fix * Automatic changelog update * Add SpriteFadeComponent to potted plants (space-wizards#31628) * Automatic changelog update * Meteor rock debuff (space-wizards#31651) * Makes meteor swarms spawn meteorite walls with 1/10 health of an asteroid wall. * Changed MeteorRock prototype base - Rebased MeteorRock to AsteroidRock from Basewall - MeteorRock now only changes the Destructible damage value * Tried to fix comments * Automatic changelog update * Fix test threading (space-wizards#31669) * Fix revenant being blocked by walls (space-wizards#31670) fix revenant being blocked by walls * Automatic changelog update * Update submodule to 233.0.0 (space-wizards#31673) * Fix broken tests directly mutating entities from wrong thread. (space-wizards#31647) * Fix broken tests directly mutating entities from wrong thread. * fix build * gundam * stuff --------- Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Fix AI singulo shenanigans (space-wizards#31556) * weh * Fix broken tests directly mutating entities from wrong thread. * fix build * gundam * weher * WHY --------- Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> * Update submodule to 233.0.1 (space-wizards#31676) * Automatic changelog update * Fix suicide logs (space-wizards#31661) Make suicide logs include the username, as well as the character(where possible) * Automatic changelog update * More ItemTogglePointLight fixes (space-wizards#31655) more ItemTogglePointLight fixes * Automatic changelog update * Allow for respawn and erase verb to be used on offline players. Also minor rewrite on respawn command and new erase command (space-wizards#30433) * Localize respawn command, allow for it to use userids, and make it use [Dependency] attributes * Make respawn verb available for offline players * Make erase available for offline players A thousand admins rejoice * Reorder verbs in code * Add erase command * Fix localisation for erase command * Address reviews and add completion to respawn command * Complete reviews which I forgor * Automatic changelog update --------- Co-authored-by: osjarw <oskariwjarvinen@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: Mervill <mervills.email@gmail.com> Co-authored-by: PursuitInAshes <pursuitinashes@gmail.com> Co-authored-by: eoineoineoin <github@eoinrul.es> Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: themias <89101928+themias@users.noreply.github.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com> Co-authored-by: PopGamer46 <yt1popgamer@gmail.com> Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com> Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com> Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com> Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com> Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: QueerNB <176353696+QueerNB@users.noreply.github.com> Co-authored-by: 12rabbits <53499656+12rabbits@users.noreply.github.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com> Co-authored-by: Dimastra <65184747+Dimastra@users.noreply.github.com> Co-authored-by: Dimastra <dimastra@users.noreply.github.com> Co-authored-by: JIPDawg <51352440+JIPDawg@users.noreply.github.com> Co-authored-by: JIPDawg <JIPDawg93@gmail.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com> Co-authored-by: stellar-novas <stellar_novas@riseup.net> Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com> Co-authored-by: saintmuntzer <47153094+saintmuntzer@users.noreply.github.com> Co-authored-by: JustCone <141039037+JustCone14@users.noreply.github.com> Co-authored-by: lunarcomets <140772713+lunarcomets@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: coolboy911 <85909253+coolboy911@users.noreply.github.com> Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com> Co-authored-by: DieselMohawk <gavin.drinka@gmail.com> Co-authored-by: RumiTiger <154005209+RumiTiger@users.noreply.github.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com> Co-authored-by: Unisol <1929445+Unisol@users.noreply.github.com> Co-authored-by: Partmedia <kevinz5000@gmail.com> Co-authored-by: MisterMecky <mrmecky@hotmail.com> Co-authored-by: AutoOtter <joshuademorris@gmail.com> Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>

Simyon264 added 17 commits January 12, 2024 15:27

Beginnings of making the breadmemes jobs easier

1f81797

stuff

81cc771

stuff pt. 2

c6c83ee

Merge remote-tracking branch 'upstream/master' into better-whitelists

e09cb3b

Stuff pt.3

2421f07

Stuff I forgot last time

15cc74e

Basic whitelist

a538164

Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist

Remove always deny condition in favor of just breaking if playtime ch…

65ab320

…eck fails

Change default whitelist

cb7ab30

Default whitelist is now the "legacy" whitelist.

localization

21c7285

Admin check

3e259e3

minor spelling change

e0c38e3

Fix build

2c5ee46

Whitelist message

ffd6ab9

Fix vars not being datafield and spelling mistakes

36b5c7a

Minor spelling mistake

36b039e

Change config for salamander

e2ab192

Simyon264 marked this pull request as ready for review January 13, 2024 12:39

Simyon264 requested review from PJB3005, DrSmugleaf and Chief-Engineer as code owners January 13, 2024 12:39

github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Jan 13, 2024

Simyon264 changed the title ~~Better whitelists~~ Automated whitelists Jan 13, 2024

Chief-Engineer reviewed Jan 14, 2024

View reviewed changes

metalgearsloth added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Feb 1, 2024

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Feb 20, 2024

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jun 26, 2024

Simyon264 added 2 commits July 5, 2024 13:13

Reviews

a1345c9

whoops

c94c03f

Simyon264 requested a review from PJB3005 July 5, 2024 11:25

github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Jul 5, 2024

Chief-Engineer reviewed Jul 6, 2024

View reviewed changes

Resources/Prototypes/whitelists.yml Outdated Show resolved Hide resolved

Resources/Prototypes/wizardsDenWhitelists.yml Outdated Show resolved Hide resolved

Resources/Prototypes/wizardsDenWhitelists.yml Outdated Show resolved Hide resolved

Simyon264 added 3 commits July 6, 2024 12:15

Explain a bit more how whitelist checking works

b2f6e58

Apply CE's review

25b8cd4

Append Membership to Blacklist and Whitelist conditions

2907daa

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 11, 2024

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 11, 2024

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 9, 2024

PJB3005 reviewed Aug 27, 2024

View reviewed changes

Merge branch 'master' into better-whitelists

3cff3a3

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 27, 2024

Fix review comments

b0211d7

PJB3005 approved these changes Aug 27, 2024

View reviewed changes

PJB3005 and others added 3 commits August 27, 2024 17:34

Uncapitalize playerConnectionWhitelist, add to ignored client prototypes

3bfdcd7

Make note count field work

af1526f

Fix cvar for thingy

46e0d13

PJB3005 merged commit f92ef41 into space-wizards:master Aug 27, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automated whitelists #23985

Automated whitelists #23985

Simyon264 commented Jan 12, 2024 •

edited

Loading

Chief-Engineer left a comment

Chief-Engineer Jan 14, 2024

metalgearsloth commented Feb 1, 2024

Simyon264 commented Feb 1, 2024

github-actions bot commented Feb 20, 2024

Chief-Engineer left a comment

Simyon264 commented Jul 6, 2024

Chief-Engineer commented Jul 8, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Aug 9, 2024

PJB3005 left a comment

PJB3005 Aug 27, 2024

PJB3005 Aug 27, 2024

PJB3005 Aug 27, 2024

		Dictionary<NetUserId, List<IAdminRemarksRecord>> cacheRemarks = new();
		Dictionary<NetUserId, List<PlayTime>> cachePlaytime = new();

Automated whitelists #23985

Automated whitelists #23985

Conversation

Simyon264 commented Jan 12, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

Chief-Engineer left a comment

Choose a reason for hiding this comment

Chief-Engineer Jan 14, 2024

Choose a reason for hiding this comment

metalgearsloth commented Feb 1, 2024

Simyon264 commented Feb 1, 2024

github-actions bot commented Feb 20, 2024

Chief-Engineer left a comment

Choose a reason for hiding this comment

Simyon264 commented Jul 6, 2024

Chief-Engineer commented Jul 8, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Aug 9, 2024

PJB3005 left a comment

Choose a reason for hiding this comment

PJB3005 Aug 27, 2024

Choose a reason for hiding this comment

PJB3005 Aug 27, 2024

Choose a reason for hiding this comment

PJB3005 Aug 27, 2024

Choose a reason for hiding this comment

Simyon264 commented Jan 12, 2024 •

edited

Loading