Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New head of security weapon:Energy Shotgun #24491

Closed
wants to merge 22 commits into from

Conversation

Boaz1111
Copy link
Contributor

@Boaz1111 Boaz1111 commented Jan 24, 2024

About the PR

I added an experimental energy shotgun with three fire modes:
Wide fire(lethal)
Narrow fire(lethal)
Disabler(non lethal)

Why / Balance

Was speaking with flare about this, the HoS really needed a unique weapon instead of a bland SMG that can be obtained in other ways. This will hopefully cause more playstyle variety for HoS. The weapon is also high risk, and a steal objective for syndies. My original idea was to add the X-01 from SS13, but flare showed me this shotgun and I instantly loved it.

Technical details

Media

Space.Station.14.2024-01-24.22-31-28.-.Trim.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: The HoS has been given a new experimental weapon:An energy shotgun with multiple fire modes. This experimental tech is highly wanted by the syndicate, and agents will try to steal it.

Copy link

ss14-mapserver-beta bot commented Jan 24, 2024

This PR contains new or changed maps:

01/24/24 21:34

@github-actions github-actions bot added Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Merge Conflict This PR currently has conflicts that need to be addressed. labels Jan 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

RSI Diff Bot; head commit 23a3210 merging into a937f05
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Battery/energy_shotgun.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Resources/Textures/Objects/Weapons/Guns/Battery/inhands_64x.rsi

State Old New Status
energy-inhand-left Added
energy-inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/Objects/Weapons/Guns/Projectiles/projectiles_tg.rsi

State Old New Status
heavylaser Added

Edit: diff updated after 23a3210

@asperger-sind
Copy link
Contributor

This looks really, really overpowered.

A rechargeable shotgun that has 4 modes that allow the user to deal with most possible combat scenarios that is also roundstart and matches if not outdamages normal shotgun options while having a clip size of 10.

It is of course in single quantity, provided you can kill the HoS, but it's not hard to acquire at all considering it's basically guaranteed the HoS will carry it, and killing the HoS is rather simple as a traitor if you get the alpha strike on them and use one of the multiple "hey I win this encounter" 1v1 options, hypopens come to mind as being the easiest option.

And the clip mechanism is kind of a drawback because you have to get to a recharger, but this doesn't matter for most encounters on the HoS part because after killing or arresting someone they can just go back to sec or bridge and recharge there, 10 clip size is plenty enough even for extended fights so trips like that aren't too bad either.

Now don't get me wrong, I love this concept, but this really needs a balance pass.

@K-Dynamic
Copy link
Contributor

This looks really, really overpowered.

A rechargeable shotgun that has 4 modes that allow the user to deal with most possible combat scenarios that is also roundstart and matches if not outdamages normal shotgun options while having a clip size of 10.

It is of course in single quantity, provided you can kill the HoS, but it's not hard to acquire at all considering it's basically guaranteed the HoS will carry it, and killing the HoS is rather simple as a traitor if you get the alpha strike on them and use one of the multiple "hey I win this encounter" 1v1 options, hypopens come to mind as being the easiest option.

And the clip mechanism is kind of a drawback because you have to get to a recharger, but this doesn't matter for most encounters on the HoS part because after killing or arresting someone they can just go back to sec or bridge and recharge there, 10 clip size is plenty enough even for extended fights so trips like that aren't too bad either.

Now don't get me wrong, I love this concept, but this really needs a balance pass.

The 8 tc eshield user:

The 8 tc eshield user then using the shotgun on the rest of the station:

@LordEclipse
Copy link
Member

Don't try to add this to every map. Before even being considered to be added, remove all the map changes, as those need to be atomized in the first place.

@BolloTea
Copy link

BolloTea commented Jan 24, 2024

Too ridiculous and strong, even for high risk, better move the x-01, this is a more balanced weapon for hos

@K-Dynamic
Copy link
Contributor

I don't like this weapon because hos will lose it and murderboners get a guaranteed source of a good weapon

@CrigCrag
Copy link
Contributor

this should be a t3 research

@asperger-sind
Copy link
Contributor

I don't like this weapon because hos will lose it and murderboners get a guaranteed source of a good weapon

They already have one via captain's antique laser gun but this adds an alternative.

@Hmeister-fake
Copy link
Contributor

pretty sure Delta-V already has an x-01 for the HoS, just port it.

@Boaz1111
Copy link
Contributor Author

I can nerf it, but debate this with flare, they requested it

@Flareguy
Copy link
Contributor

Flareguy commented Jan 24, 2024

Okay, going point-through-point:

  • The main reason for having this over the X-01 (HOS's SS13 weapon) is that the X-01 was always kind of boring. Most people probably couldn't tell you how good it was because it's basically just another laser gun but Slightly Better:tm: and with an ion fire mode. In theory, this provides an interesting spin on the gun and makes it genuinely unique and valuable, like any good objective item should be.

  • Traitors stealing this gun is kind of a given, I don't really see the point in this being a bad thing unless it's ridiculously overpowered.

  • Shotgun disablers should be conceptually fine since these are supposed to do less damage per shot (they use the SMG disabler shots.)

  • I'm kind of indifferent on ion, but it's only 1 bolt per shot so it should be fine, it was a feature of the X-01. If it makes the gun too versatile it probably wouldn't be out of the question to remove.

  • 10 shots probably is pretty ridiculous considering how much pain this thing can dish out in theory.

@Boaz1111
Copy link
Contributor Author

Okay, going point-through-point:

  • The main reason for having this over the X-01 (HOS's SS13 weapon) is that the X-01 was always kind of boring. Most people probably couldn't tell you how good it was because it's basically just another laser gun but Slightly Better:tm: and with an ion fire mode. In theory, this provides an interesting spin on the gun and makes it genuinely unique and valuable, like any good objective item should be.

  • Traitors stealing this gun is kind of a given, I don't really see the point in this being a bad thing unless it's ridiculously overpowered.

  • Shotgun disablers should be conceptually fine since these are supposed to do less damage per shot (they use the SMG disabler shots.)

  • I'm kind of indifferent on ion, but it's only 1 bolt per shot so it should be fine, it was a feature of the X-01. If it makes the gun too versatile it probably wouldn't be out of the question to remove.

  • 10 shots probably is pretty ridiculous considering how much pain this thing can dish out in theory.

How many shots do you suggest? Five?

@Flareguy
Copy link
Contributor

Five or four is probably good to put it at for now, considering the relative power of the shotgun.

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make mapping changes in the same pr.

@BolloTea
Copy link

The main reason for having this over the X-01 (HOS's SS13 weapon) is that the X-01 was always kind of boring. Most people probably couldn't tell you how good it was because it's basically just another laser gun but Slightly Better:tm: and with an ion fire mode. In theory, this provides an interesting spin on the gun and makes it genuinely unique and valuable, like any good objective item should be.

In part I agree with you. But you can always improve, refine or look at it from a new angle. Perhaps at the moment, for x-01, ion damage will be more useless, unlike disabler. As a last resort, it will be possible to look at the Dominator and do something based on its model. (Lethal, non-lethal and taser). Although these are all assumptions and ideas that most likely no one will consider in this request.

@VasilisThePikachu
Copy link
Member

Did we not have a freeze for new weapons?

@github-actions github-actions bot removed Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Merge Conflict This PR currently has conflicts that need to be addressed. labels Jan 27, 2024
Comment on lines 729 to 731
- type: ProjectileBatteryAmmoProvider
proto: CartridgeEnergyShotgunWide
fireCost: 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this, it shouldn't be necessary and if it is then BatteryWeaponFireModes code needs fixing until it isn't.

@Doc-Michael
Copy link
Contributor

I don't think it's been mentioned before, but what size is the Gun going to be?
Having it be 4x2 would be wonderful, would also match the size of the Enforcer.

@metalgearsloth
Copy link
Contributor

@Boaz1111 is this still being worked on.

@metalgearsloth metalgearsloth added the Status: Stale This PR has been abandoned and will be closed within a week. label Apr 20, 2024
@Boaz1111
Copy link
Contributor Author

not currently

@metalgearsloth metalgearsloth added Status: Derelict This PR appears to be abandoned but might contain something that can be salvaged. and removed Status: Stale This PR has been abandoned and will be closed within a week. labels Apr 28, 2024
@Boaz1111
Copy link
Contributor Author

Going to undraft and work on this once #27773 gets merged

@EmoGarbage404 EmoGarbage404 reopened this Aug 3, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Aug 3, 2024
@Boaz1111
Copy link
Contributor Author

Boaz1111 commented Aug 4, 2024

closing this because I am doing the scorched earth strategy of making a new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Status: Derelict This PR appears to be abandoned but might contain something that can be salvaged. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.