Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Industrial Reagent Grinder #25020

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Conversation

Boaz1111
Copy link
Contributor

@Boaz1111 Boaz1111 commented Feb 7, 2024

About the PR

Added an industrial reagent grinder, that works like a recycler(can use conveyors). It mass-grinds things, at the cost of only being 0.9 times as efficient. It's researchable in the hydroponics research

Why / Balance

Botany grows produce for chem
Lot of produce
Chem can't grind it all
Work goes to waste
This allows for rapid grinding of plants, causing the chem-botany teamwork to grow.
factorio real

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Boaz1111

  • add: Added an industrial reagent grinder to the basic hydroponics research. It grinds things into reagents like a recycler.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. No C# For things that don't need code. labels Feb 7, 2024
@K-Dynamic
Copy link
Contributor

K-Dynamic commented Feb 7, 2024

How does it work

I'd rather making material reclaimers buildable since it grinds as you put stuff in, then you remove solutions from it with a beaker

@tutoumi
Copy link

tutoumi commented Feb 7, 2024

I think its a good Idea if it give more reagent from the mat we grind because, for exemple, the bandana peel drug is too hard to make with a normal grinder that nobody even remember it existe

@Boaz1111
Copy link
Contributor Author

Boaz1111 commented Feb 7, 2024

How does it work

I'd rather making material reclaimers buildable since it grinds as you put stuff in, then you remove solutions from it with a beaker

that's exactly how this works

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 7, 2024

Botany grows produce for chem
Lot of produce
Chem can't grind it all
Chem/Bot asks science for cool tech
"We're rushing experimental go away"
Work goes to waste anyway

@K-Dynamic
Copy link
Contributor

K-Dynamic commented Feb 7, 2024

that's exactly how this works

I see, that's convenient then; I thought there'd be a UI like that of regular reagent grinder

@Carmell0
Copy link

Carmell0 commented Feb 7, 2024

ITS FINALLY REAL IVE BEEN ADVOCATING FOR THIS THING FOR MONTHS

@Boaz1111
Copy link
Contributor Author

Boaz1111 commented Feb 7, 2024

I KNOW YOU INSPIRED ME TO MAKE THIS

@Aisu9
Copy link

Aisu9 commented Feb 7, 2024

what is the point of the industrial reagent grinder when you can use a material reclaimer? you wont have material lost and you will grind items instantly

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 8, 2024

what is the point of the industrial reagent grinder when you can use a material reclaimer? you wont have material lost and you will grind items instantly

reclaimer isn't always mapped in the best places (good luck getting into cargo to use it if it's mapped there (which I never understood)) + sometimes it's next to disposals (scary!) ++ unanchoring it is hard because it grinds wrenches

@deltanedas
Copy link
Contributor

unanchoring it is hard because it grinds wrenches

krill issue shrimply turn it off first

@Varen
Copy link
Contributor

Varen commented Feb 8, 2024

Why make it less efficient? It's kind of counter intuitive and encourages using the earlier machine to optimize instead, I'd look for another downside like the other machines do, such as waste heating issues.

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 8, 2024

Why make it less efficient? It's kind of counter intuitive and encourages using the earlier machine to optimize instead, I'd look for another downside like the other machines do, such as waste heating issues.

I think at the point you need this machine you probably have enough plants on your counter to let some of their chems go to waste. If you only have 3 deus leaves you want to get as much omnizine out of them as possible but when you have 20 leaves you just want to get it over with.

@deltanedas
Copy link
Contributor

entirely countered by eggs existing
just crack into bucket and dump into chemmaster

@K-Dynamic
Copy link
Contributor

entirely countered by eggs existing just crack into bucket and dump into chemmaster

Ideally we're trying to get away from that since it adds another rng step to botany, especially if there is a better grinder for both chef and chem

@UbaserB
Copy link
Member

UbaserB commented Feb 9, 2024

where is the photo/video showcasing it

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 9, 2024

where is the photo/video showcasing it

it's just a material reclaimer but reskinned

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 9, 2024

entirely countered by eggs existing just crack into bucket and dump into chemmaster

eggmeta is annoying

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Feb 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@deltanedas
Copy link
Contributor

this is just a worse material reclaimer theres no reason for this to be made

@UbaserB
Copy link
Member

UbaserB commented Feb 11, 2024

this is just a worse material reclaimer theres no reason for this to be made

simple solution, make it work better for plants and not work for anything else

@Boaz1111
Copy link
Contributor Author

Yeah I'm probably going to tweak it to

  1. Make it work like a recycler(conveyor belt real)
  2. Up the efficiency to like 1.0 or 1.1?

@deltanedas
Copy link
Contributor

conveyor belt real would make it god tier for auto egg since its now fully automated

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Feb 12, 2024
@Fildrance
Copy link
Contributor

New sprite and disable processing of anything but plants, or bust!

@Boaz1111
Copy link
Contributor Author

New sprite and disable processing of anything but plants, or bust!

I'd rather a maintainer give their review on the concept in general as well as if it really needs a new sprite.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Mar 17, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Mar 27, 2024
@metalgearsloth
Copy link
Contributor

sure ig

@metalgearsloth metalgearsloth merged commit 6ef592d into space-wizards:master Mar 30, 2024
11 checks passed
@Boaz1111 Boaz1111 deleted the thegoddamnuhh branch September 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.