Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add carp hardsuit for traitors #25155

Merged
merged 10 commits into from
Jun 16, 2024
Merged

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Feb 12, 2024

About the PR

add valid version of carp suit to uplink
it protects from space and adds you to dragon faction

depends on #25154

Why / Balance

it costs 4 tc since:

  • eva suit is 2 tc
  • carp suit has no slowdown, 3tc
  • carp suit isnt valid, 5tc
  • shiva and shit will probably start eating you since theyre just as well fooled as carp, 4tc

open to balancing

all carp get fooled but not sharkminnow they too smart

pro strat:

  1. be lone salv
  2. buy carp hardsuit
  3. rescue lost fishies from wrecks
  4. put them in a crate then let them out for budget fishops with lots of prep work
  5. take off hood/helmet when theres a lone fish so people think since you being chased you couldnt have done it...

Technical details

carp moved to Dragon faction since that makes sense and carp suit making you immune to ticks and what not doesnt make sense (so many mobs are simple hostile)
code is fairly simple but it handles the edge case of someone already in Dragon faction

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • add: Added the Carp Hardsuit to the uplink which is spaceproof and makes carp think you are one of them.

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 12, 2024

>be lone salv
>buy this
>only take dragon expeds
>free gamer loot

jokes aside this is awesome it revives my dream of cognizining a space dragon

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 12, 2024

also since it's a softsuit shouldn't the helmet be separate

@deltanedas
Copy link
Contributor Author

its a onesie the hood just unfolds over your head and its airtight due to space magic

@K-Dynamic
Copy link
Contributor

buy carp hardsuit and emag
emag biofabricator
print carp cubes
spray 20 cubes at once
grind corpses and make more carps
vibe with space ninja and call for space dragon
vibe with space dragon

@deltanedas
Copy link
Contributor Author

biofab is stupid expensive so you will need to also take over cargo or unsus ask them for 5 stacks of plasma

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 12, 2024

biofab is stupid expensive so you will need to also take over cargo or unsus ask them for 5 stacks of plasma

can confirm biofab needs like 6 monkeys to make 1.7 kobolds

@Anzarot121
Copy link
Contributor

Will this faction move fix the bug where normal dragon carp attack zombie carp, but they don't respond?

@deltanedas
Copy link
Contributor Author

doubt it but ill test it with the rest of the stuff

@github-actions github-actions bot added Merge Conflict This PR currently has conflicts that need to be addressed. labels Mar 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Mar 13, 2024
@mirrorcult mirrorcult added the Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze. label May 6, 2024
@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
@deltanedas
Copy link
Contributor Author

open

@AJCM-git AJCM-git reopened this Jun 14, 2024
@deltanedas deltanedas marked this pull request as ready for review June 14, 2024 00:32
@metalgearsloth metalgearsloth merged commit 1cb9f5d into space-wizards:master Jun 16, 2024
11 checks passed
@deltanedas deltanedas deleted the valid-suit branch June 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants