Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Refund Fix #26251

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Store Refund Fix #26251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Content.Server/Store/Systems/StoreSystem.Ui.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,6 @@ private void OnBuyRequest(EntityUid uid, StoreComponent component, StoreBuyListi

if (!IsOnStartingMap(uid, component))
component.RefundAllowed = false;
Comment on lines 166 to 167
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you not just wrap this in a check for whether or not the store is able to refund? or is setting it to true just not needed at all.

Copy link
Contributor Author

@keronshb keronshb Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wizard should be able to refund before they leave their ship, but not after. If we ever get a cult it'd be up for debate if they should be able to buy/refund powers offstation.

else
component.RefundAllowed = true;

//subtract the cash
foreach (var (currency, value) in listing.Cost)
Expand Down
Loading