Improved Adminhelp sound #26319
Closed
Improved Adminhelp sound #26319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+219
to
+223
|
|
||
| - files: ["metal-pipe-falling.ogg"] | ||
| copyright: "Taken from thenotcheeseman via freesound.org and mixed from stereo to mono." | ||
| license: CC0-1.0 | ||
| source: "https://freesound.org/people/thenotcheeseman/sounds/679206/" |
There was a problem hiding this comment.
I'm reasonably sure this is not licensed properly and is a stolen sound effect from the original pack from the 90s.
There was a problem hiding this comment.
Unfortunately, I could not find another original. (＞︿＜)
Is this source definitely not suitable as the original?
|
new player experience improved by 110% on april fools day |
|
Sloth please just this once please |
|
i too will beg if necessary |
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
Merge Conflict
|
Oh god please i require this |
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
as i figured out in #26078 metal pipe sound can't be used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Replaced the adminhelp sound with a more attractive sound of a falling pipe
Why / Balance
During the chaos around April 1, people may not notice that an admin is writing to them. Therefore, I believe that the sound needs to be improved so that everyone can hear it clearly.
Technical details
I hope I didn't make any stupid mistakes in the PR.
Media
sus.mp4
Breaking changes
Changelog
🆑