Pomegranate & Bombegranate #26407
Closed
Pomegranate & Bombegranate #26407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Changes: Sprites
|
RSI Diff Bot; head commit 29e62ff merging into af6a2d7 Resources/Textures/Objects/Specific/Hydroponics/bombegranate.rsi
Resources/Textures/Objects/Specific/Hydroponics/pomegranate.rsi
Resources/Textures/Objects/Weapons/Guns/Projectiles/organic.rsi
|
|
"I swear officer, they're omnizine grenades!" |
|
Can we call them pomegrenades, or is that ripping off Barotrauma? |
|
I am cool with that. It's reasonable pun to make. |
How about "bombegranate"? |
|
100% bombegranate |
|
Bombegranate it is. |
…rds#26287) Updated calls to SharedPhysicsSystem methods
* Cleaner Grenade Added Cleaner Grenade * Sprite update Draw issue moment * Removed from jani closet | added box of cleanades
* Wearable Instrument Base + Changed harmonica base Created the BaseWornInstrument base and updated the Harmonica to use it, being equipable in the neck slot. * Update instruments_wind.yml * compositions are cool and awesome
…e-wizards#26383) * Fix mailing units turning into disposal units while recharging. The states were hardcoded. * Fix error handling * Make default states constants
* Adds Church Bells * I'm dumb. * The bell is no longer haunted. * forgot attributions * change sounds so scary law no hunt * One day I'll stop needing to make an immediate micro-commit. One day. * God damn it.
* resprites labcoats again * fix tests
* SS14-17313 Chat Censorship Systems Adds some systems to manage chat censorship: 1. No-op: does nothing 2. SimpleCensor: a regex-free censor with a variety of rules to use 3. RegexCensor: a censor that uses regex. This exposes a singleton backed by a builder pattern (ChatCensor) that is set up, probably during the code init phase, and then globally available for your censorship needs. * Migrate to Shared * Add a reset function to the builder. * Resolve PJB's feedback; add unit tests
…s#26250) * Make mind shield implants unable to be implanted more than once * Default AllowMultipleImplants to false and update implanters.yml * Use TryComp instead of TryGetComponent * Deny multiple implants for fun implants too. * Make comment more precise
* nerf ninja steal objective * fubar
… containers (space-wizards#26430) * Reduces size of smaller cartons * Fix trash bottles/cartons --------- Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
* Fix atmos NAN error * Remove redundant yaml entries
Fix Mail Unit
* Adds the option for you to toggle your OOC Patron color visibility to yourself and others. * Makes the button magically disappear if you arent a patron
space-wizards#26708) Fix bug and formatting
Make zombie fix
…26658) * Suit sensors now know the 'total health' of an entity * Missed the constructor 😔
fix Co-authored-by: GeneralGaws <limonmessi@mail.ru>
- Added Pomegranate & Grenade Fruit - SolutionInjectOnCollideSystem fixed cases where trying to inject more than available space - ChemicalAmmoSystem fixed issue with dividing Integer value instead of Float/FixedPoint value - ClusterGrenadeSystem implemented AmmoShotEvent
fixed cargo price for seed crate
added ContainerContainer
drteaspoon420
requested review from
Jezithyr,
Partmedia,
EmoGarbage404,
DrSmugleaf,
Emisse and
Chief-Engineer
as code owners
github-actions
bot
added
Status: Needs Review
|
A classic mistake that I have also made 😆 |
|
what happend? is it still worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
Wanted to include something inspired by 'exploding' plants in nature that use violent explosion to send seeds in wider area. Usually the method is to store a lot of kinetic energy as it grows into strained shape or dries into one. Some plants have chemical reaction to produce some sort of propulsion.
Pomegranate was added just to provide pun for the mutation as the Bombegranate ,while inspired by Sandbox Tree Fruit, does not exist.
Technical details
Added prototypes for seeds & produce, localization strings and artwork for Pomegranate & Bombegranate
Bombegranate also has prototypes and artwork for seed projectiles.
Bombegranate's chemical contents are 9u (at potency 10) divided to Sulfur,Hydrogen and Ethanol. It Juices into Welding Fuel.
Bombegranate when thrown explode into ten (10) seed projectiles delivering all of the fruit's chemical contents evenly divided with the projectiles (0.9u per projectile).
For the Bombegranatet to work I had to:
ClusterGrenadeSystem.csimplemented AmmoShotEvent when usingGrenadeType.Shootto enable use ofChemicalAmmocomponentChemicalAmmoSystem.csfixed issue with dividing Integer value instead of Float/FixedPoint value. More than 1 projectiles caused value to be zero.SolutionInjectOnCollideSystem.csfixed cases where trying to inject more than available space. While not issue in most casesMedia
grentree-grow.webm
grentree-throw.webm
Updated Bombegranate sprites:
Breaking changes
There should be no breaking changes.
Changelog
🆑 DrTeaSpoon