Paramedic & Security Crew Monitors

[rosieposieeee]

About the PR

Added Paramedic and Security crew monitors, renaming the base one to CMO's. The Paramedic one only shows crit/injured crew, and the Security one only shows Security and Command, crit or not.

Paramedics start with the paramedic one, and Wardens start with the sec one. CMO and HoS have an extra in their lockers as well.

monitorrr.mp4

Why / Balance

Removing the paramedic monitor was understandable, but unfortunate, and I've always wanted a paramedic monitor that only shows crit/dead people for convenience anyway. I can remove the sec monitor from spawning with HoS/Warden if people think its bullshit; it's more there for brigmedic downstreams (of which I play on!) and just as an example of how to use the department/role controls, but having a monitor for prisoners might be really useful.

Technical details

I modified the crew monitor to take some extra parameters, allowing monitors to select who they want to see. Theoretically you could probably also use this to search in the UI of the full monitor (ie narrow down to just security), but I haven't touched UI stuff yet.

I messed around with adding a noise if someone's crit/dead, but it didn't work out so well, I'd have to learn more about the codebase to get something like that to work. (Needs a mute toggle. By god it needs a mute toggle.)

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

• add: Added Paramedic and Security Handheld Crew Monitors with more limited functionality.

[github-actions]

RSI Diff Bot; head commit 5706011 merging into a05f952
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Medical/handheldcrewmonitor.rsi

State	Old	New	Status
scanner			Modified
paramedic			Added
paramedic_icon			Added
security			Added
security_icon			Added

Edit: diff updated after 5706011

[JackSage]

Perhaps sec also shows people with tracking implants?

[Dutch-VanDerLinde]

Perhaps sec also shows people with tracking implants?

normal crew monitor already does this

[rosieposieeee]

Perhaps sec also shows people with tracking implants?

if that was stored in SuitSensorStatus, i would filter it in right now, but the crew monitoring system is not privy to that data and i don't have time rn to look into it; could be a future PR. regardless, if they're sec or command, they'll still be included since that works just like regular suit sensors.

[Yousifb26]

Is there anyway to replace server not found with something like ‘no crew are currently dying’. It would be a good quality of life to see when the server is down versus it just saying no server because no one is dying

[rosieposieeee]

Is there anyway to replace server not found with something like ‘no crew are currently dying’. It would be a good quality of life to see when the server is down versus it just saying no server because no one is dying

i changed it to say 'no server found or no listings available', which i figured was vague enough to work. unfortunately, that is set just by having no data sent to the monitor, so the monitor literally does not know whether the server is down or no one is injured. like with the tracking implants, i would have to modify code further away from the functionality of this PR, which mostly relies on data that was already available to the system, so that could be a future PR if its too confusing (or i could just make the text more explicit)

[JackSage]

Perhaps sec also shows people with tracking implants?

normal crew monitor already does this

I'm saying for the security monitor to show people with tracking implants.

"The Security one only shows Security and Command, crit or not."

[deltanedas]

use mobstate instead

[rosieposieeee]

did this but for some reason this.. just... doesn't work...??? like these never return true even when the mob is crit/etc.

[deltanedas]

inherited so remove this line

[rosieposieeee]

the sprite changed and the description is different...?

[lzk228]

the parent BaseHandheldCrewMonitor already has the path written so you need just to change state for children (what you already did the line below)

[Simyon264]

I like the paramedic crew monitor but why would security need one?

[blueDev2]

I like the paramedic crew monitor but why would security need one?

In some ss13 forks, one of the warden's jobs is to check the health of the officers. It's useful for sec to know if and where their officers' dead bodies are. Might have some balance implications though.

[rosieposieeee]

I like the paramedic crew monitor but why would security need one?

crazily enough there is a Why / Balance section of the pr. that explains this

[lzk228]

looks like you forgot to add to migration yml

[rosieposieeee]

looks like you forgot to add to migration yml

ah, more like didn't know this was a thing, whoops. guess i'll remove that map change

no idea how to squash around the upstream merges so that itll stop thinking there was a map change though

[LordCarve]

I like one for paramedic. Weaker than CMO's and addresses the stupid handsmedat of CMO giving theirs to paramedic every round.

Not sure about the security one:

1. We generally don't add things "for downstreams". They are free to add/remove the things they want themselves
2. Brigmed/Warden argument doesn't convince me. IMO they should have fixed-emplacement crew monitor computers (whether with security/paramedic flavor is up for discussion) rather than handheld ones. IIRC on some maps they already have them.
   Warden/brigmed-specific crew monitors shouldn't be handheld if they are intended to be used by jobs that are discouraged from leaving their post (brigmed out of security & wardenloose). If you leave your post, then you can't keep tabs on crew. Seems like a reasonable drawback.
   It is paramedic's job is to find hurt people with pinpoint accuracy. A brigmed is not paramedic and giving warden handheld crew monitoring is just encouraging wardenloosapocalypse.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[rosieposieeee]

i can remove the sec one if thats the main holdup for merging this

[JackSage]

I thought a cool way to do this instead would be for paramedics to get a special pinpointer (not the nuke pinpointer), by default it would track nothing. The paramedic can go to a crew monitoring console and they can select the pinpointer to track someone. (i.e. if John Doe is crit w/ cords on, you use the crew monitor, track him, and then the pin pointer will point to him) The pinpointer will stop tracking if they turn their cords off, a jammer is active near them, or their jumpsuit/skirt is removed.

[lzk228]

in everything else yml part looks fine to me

[lzk228]

the parent BaseHandheldCrewMonitor already has the path written so you need just to change state for children (what you already did the line below)

[lzk228]

same here

[LankLTE]

Sec having their own crew monitor just to bypass med isn't something we want. Paramedic having their own crew monitor makes the CMO's less unique as an item and kind of comes across like a way to revert the change.

[rosieposieeee]

Sec having their own crew monitor just to bypass med isn't something we want. Paramedic having their own crew monitor makes the CMO's less unique as an item and kind of comes across like a way to revert the change.

what about the code changes i did that allow them to exist, for downstreams? i know you guys 'dont do things for downstreams' but its impossible to do this with yml changes alone.

[rosieposieeee]

i really dont know why i waste my time. fuck it

[ColdDead]

Please give the Paramedic it, is so bad right now. Crew keep drag the Injured crew away and TELL NOTHING. Same problem on rp...