Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade that sends you to OpenDream Paradise station #26476

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

Simyon264
Copy link
Contributor

@Simyon264 Simyon264 commented Mar 27, 2024

About the PR

Adds an arcade that, when used, sends you to paradise station. It forces you to sleep for 60 seconds while adding a little text upon examination that indicates that you are in paradise station.

Why / Balance

Suggestion from #contributors.
I do have indirect permission from ike709, moderator and contributor for open dream, to connect people to open dream servers. But I have no idea if that is enough. I asked around on the Open Dream discord server and will update, till then I will keep this PR as a draft.

See this discord message.

Update: According to amylizzle, the open dream servers are hosted by PJB, which means this is allowed per Hub rules. Hooray! Also because amylizzle said that OpenDream is administered largely by wixoa, I also asked him.

Update 2: Got permissions from wixoa.
image

Technical details

Honestly, this is the first time I ever coded UI, and I am so sure that I produced shitcode. But I hope it's good enough for an april fools joke.

Media

8mb.video-WpU-U7TA8Vzw.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 Simyon

  • add: There are new arcade machines around that let you play space station 13!

@github-actions github-actions bot added April Fools (merge for one day) Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design labels Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

RSI Diff Bot; head commit 1f4ec82 merging into 9d2c1c4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Machines/arcade.rsi

State Old New Status
paradise Added

Edit: diff updated after 1f4ec82

@Flareguy
Copy link
Contributor

For april fools, this should probably just replace normal arcade machines in migration, since it's not like they'll be able to mapped anyways.

@Simyon264
Copy link
Contributor Author

This adds it to the random arcade spawner, meaning it will spawn in with the other arcades. At least on most maps.

@Flareguy
Copy link
Contributor

This adds it to the random arcade spawner, meaning it will spawn in with the other arcades. At least on most maps.

I immediately noticed my mistake after posting, oops.
Anyways, you could probably still serve to weigh this more then the others by putting them in a rare prototype group. You'd probably want more people to play it anyways since it's only for april fools.

@Simyon264
Copy link
Contributor Author

Anyways, you could probably still serve to weigh this more then the others by putting them in a rare prototype group. You'd probably want more people to play it anyways since it's only for april fools.

How? I am unsure how they work.

@Flareguy
Copy link
Contributor

Add

Anyways, you could probably still serve to weigh this more then the others by putting them in a rare prototype group. You'd probably want more people to play it anyways since it's only for april fools.

How? I am unsure how they work.

To my understanding, from looking at the maint loot spawner: you need to add a rarePrototypes field and set rareChance under it. You should probably set chance to make up the difference of whatever you have rarePrototypes set to, otherwise I think there's a chance the spawner will just spawn nothing.
You'd be looking at something like this, to my understanding:

    prototypes:
      - ParadiseArcade
      chance: 0.50
    rarePrototypes:
      - BlockGameArcade
      - SpaceVillainArcadeFilled
      rareChance: 0.50
    

@Simyon264
Copy link
Contributor Author

Alright, thanks. Will implement soon.

@VasilisThePikachu
Copy link
Member

the open dream servers are hosted by PJB, which means this is allowed per Hub rules

Still wanna see permission from her and a quick glance that this is fine.

@PJB3005 require your review.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Mar 27, 2024
@K-Dynamic
Copy link
Contributor

Imagine being able to cross-message between servers

@Simyon264 Simyon264 marked this pull request as ready for review March 29, 2024 15:19
@Simyon264
Copy link
Contributor Author

Permission from PJB aquired.

@metalgearsloth metalgearsloth merged commit 731f068 into space-wizards:april-fools-2024 Mar 30, 2024
11 checks passed
using JetBrains.Annotations;
using Robust.Client;
using Robust.Shared.Timing;
using Serilog;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong logger but not master so don't care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah. That was very much just temporary. Then it became permanent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
April Fools (merge for one day) Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants