Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename baseball bat to wooden club to better communicate it's improvised nature. #26477

Closed
wants to merge 2 commits into from

Conversation

Blackern5000
Copy link
Contributor

About the PR

The baseball bat is now named the wooden club. Very simple.

Why / Balance

I feel like crafting a baseball bat out of some random wooden planks is a bit odd, especially because you could argue against it being contraband since a baseball bat isn't inherently a weapon. Renaming it to a wooden club makes more sense and makes it more reasonable to confiscate as an improvised weapon.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changed the ID of the baseball bat to WoodenClub, as well as the knockback stick's parent ID since it was parented to the baseball bat. Not sure if there are any other prototypes parented to the baseball bat.

Changelog

  • tweak: Baseball bats are now named wooden clubs.

@github-actions github-actions bot added the No C# For things that don't need code. label Mar 27, 2024
@Dutch-VanDerLinde
Copy link
Contributor

Change log broken

@EmoGarbage404
Copy link
Member

EmoGarbage404 commented Mar 27, 2024

I mean the sprite is clearly a baseball bat so just renaming it seems extremely weird. It doesnt look anything like a club

@deltanedas
Copy link
Contributor

make it require a saw or something to make if you think its too easy

@Blackern5000
Copy link
Contributor Author

make it require a saw or something to make if you think its too easy

That still raises the point of people arguing "It's a baseball bat, not a weapon!" to sec.

@Blackern5000
Copy link
Contributor Author

I mean the sprite is clearly a baseball bat so just renaming it seems extremely weird. It doesnt look anything like a club

I can edit the sprite some to make it look more wooden club-like

@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. label Mar 27, 2024
Copy link
Contributor

RSI Diff Bot; head commit 034e423 merging into bd27727
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Melee/baseball_bat.rsi

State Old New Status
equipped-BACKPACK Modified
icon Modified
inhand-left Modified
inhand-right Modified
wielded-inhand-left Modified
wielded-inhand-right Modified

@keronshb
Copy link
Contributor

I don't think this distinction is needed. A baseball bat can be considered a weapon.

Also it's listed in SOP
https://wiki.spacestation14.io/wiki/Standard_Operating_Procedure

@keronshb keronshb closed this Mar 27, 2024
@Blackern5000
Copy link
Contributor Author

I don't think this distinction is needed. A baseball bat can be considered a weapon.

Also it's listed in SOP https://wiki.spacestation14.io/wiki/Standard_Operating_Procedure

I think making it more clear is really good, especially for newer players. I don't see why the improvised wooden weapon is a pristine baseball bat.

@Blackern5000 Blackern5000 deleted the woodenclub branch May 10, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants