[BugFix] Persist Job Restrictions When New User Late Joins #26498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are unrelated to this CL |
Huxellberger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Small 1 line change to new Late Join UI caching logic.
Why / Balance
Fix potential bug where late joiners would unlock roles that they do not meet the requirements for. (only on client UI side...not server side)
Technical details
Since we only considered the available slots remaining after caching if there was a role you previously missed the requirements for we'd ignore that prior restriction and open it up on the Client UI. We now make sure to persist the previous restrictions. Apologies for missing this case on my first PR.
Media
Additional clarity is best achieved from looking at my previous PR and attached video : #26483
Breaking changes
Changelog
🆑 Jake Huxell