Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head Chef Hat #27559

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

Ghagliiarghii
Copy link
Contributor

@Ghagliiarghii Ghagliiarghii commented May 1, 2024

About the PR

Added a new load out item for experienced chefs (players with more than 10 hours in chef): A very tall version of the default chef hat

Why / Balance

More loadout options / senior clothing are fun, this hat gives a good idea that a player has experience in the kitchen and can likely be relied upon to come up with good recipes or direction for other chefs (chef can be overwhelming sometimes with all the orders, standard reasoning for other departments to have senior clothing). Also, people have been asking for a very tall/long hat for a while (it's funny) and this satisfies that.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    master chef hat ss14

Changelog

🆑

  • add: Added new hat for experienced chefs! (Find in loadouts)

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels May 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

RSI Diff Bot; head commit b92ec27 merging into 222d3b5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/chefhathead.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Head/Hats/chefhatsous.rsi

State Old New Status
equipped-HELMET-hamster Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after b92ec27

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to call it that considering the trademark.

@Ghagliiarghii
Copy link
Contributor Author

Ah good point I'll come up with alternative names

@Everturning
Copy link

two points:
1: needs to be taller
2: needs to be harder to get. i want mfs spending 24 hours as chef to get this hat. or you can tie it to an accomplishment like "made 2x suppermatter and super bite in the same shift". idk

@Ghagliiarghii
Copy link
Contributor Author

two points: 1: needs to be taller 2: needs to be harder to get. i want mfs spending 24 hours as chef to get this hat. or you can tie it to an accomplishment like "made 2x suppermatter and super bite in the same shift". idk

I have one pixel of headroom right now with 32x64 rsi, I could make it even taller than 64 rsi but it already causes some silliness with how big it is and I don't want to push it. I'm not sure how to implement the tie to an achievement thing but am open to changing time requirements I just don't want to go above 60 because cooking is not as hard as other departments or under 10 because that's passenger and that's nothing. I think 10-30 somewhere is the sweet spot? Unsure though.

@Ghagliiarghii Ghagliiarghii changed the title Masterchefhat Head Chef Hat May 1, 2024
Copy link
Contributor Author

@Ghagliiarghii Ghagliiarghii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part one of removing master chef name

@MACMAN2003
Copy link
Contributor

master chef?
Untitled

@Everturning
Copy link

two points: 1: needs to be taller 2: needs to be harder to get. i want mfs spending 24 hours as chef to get this hat. or you can tie it to an accomplishment like "made 2x suppermatter and super bite in the same shift". idk

I have one pixel of headroom right now with 32x64 rsi, I could make it even taller than 64 rsi but it already causes some silliness with how big it is and I don't want to push it. I'm not sure how to implement the tie to an achievement thing but am open to changing time requirements I just don't want to go above 60 because cooking is not as hard as other departments or under 10 because that's passenger and that's nothing. I think 10-30 somewhere is the sweet spot? Unsure though.

15-24 hours seems best, plenty of time to learn most recipes, and you gotta devote at least a day to getting on that grind(er)

@Ghagliiarghii
Copy link
Contributor Author

master chef? Untitled

God, I wish, copyright law strike again tragically

@Ghagliiarghii
Copy link
Contributor Author

Ghagliiarghii commented May 1, 2024

15-24 hours seems best, plenty of time to learn most recipes, and you gotta devote at least a day to getting on that grind(er)

I'll make it 24 hours. Seems like a good round number around where I was thinking.

@metalgearsloth
Copy link
Contributor

15-24 hours seems best, plenty of time to learn most recipes, and you gotta devote at least a day to getting on that grind(er)

I'll make it 24 hours. Seems like a good round number around where I was thinking.

Just leave it at what it was, it doesn't need to be unnecessarily gatekept.

@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label May 1, 2024
@Tayrtahn
Copy link
Member

Tayrtahn commented May 1, 2024

Ooookay. So.

I just want to declare that if both this and #25950 get merged at some point, I'm going to make this hat able to fit a raccoon inside, and I'm not going to take no for an answer.

@Ghagliiarghii
Copy link
Contributor Author

Any idea why YAML Linter is failing? I modified code copied from other departments in the loadouts folder

@Hmeister-real
Copy link
Contributor

Any idea why YAML Linter is failing? I modified code copied from other departments in the loadouts folder

check for spacing and tabs, maybe you messed up somewhere with formatting

(another victim of my terrible workflow for this project, error was introduced when I manually copied the text into github from a working local copy)
@baddiePRO
Copy link

master chef?
Untitled

"mind telling me what you're doing in that kitchen?"

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels May 4, 2024
@mirrorcult mirrorcult added the Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze. label May 6, 2024
@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
@Ghagliiarghii
Copy link
Contributor Author

I would like this one reopened please, I'm planning on making content similar to this also (although less funny)

@Emisse Emisse reopened this Jun 14, 2024
@Ghagliiarghii Ghagliiarghii mentioned this pull request Jun 15, 2024
@AJCM-git AJCM-git removed the Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze. label Jun 17, 2024
@Boaz1111
Copy link
Contributor

master chef?
Untitled

"mind telling me what you're doing in that kitchen?"

Sir, flipping burgers, sir

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the hamster variants, also it's too large at 4 tiles high.

@metalgearsloth metalgearsloth added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Jun 18, 2024
@Ghagliiarghii
Copy link
Contributor Author

Remove the hamster variants, also it's too large at 4 tiles high.

The hamster one is unfortunate but I'll do it because it'll let me make the texture smaller. Would making the extra tall one an admin-spawn only item be a reasonable compromise?

@metalgearsloth
Copy link
Contributor

Remove the hamster variants, also it's too large at 4 tiles high.

The hamster one is unfortunate but I'll do it because it'll let me make the texture smaller. Would making the extra tall one an admin-spawn only item be a reasonable compromise?

yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.