-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containment Field Alarms #27640
base: master
Are you sure you want to change the base?
Containment Field Alarms #27640
Conversation
Resources/Locale/en-US/singularity/components/containment-component.ftl
Outdated
Show resolved
Hide resolved
Co-authored-by: exincore <me@exin.xyz>
Not a huge fan of this for multiple reasons:
An actual fix would be to redesign singularity containment to require more than one failure to completely break, so there's more time before escape and sabotage is harder due to the need to sabotage multiple things. |
had a quick chat with someone about this, maybe it'd be better to give emitters the alert functionality ("be loud if depowered when locked") instead if we go this route? It feels weird to put it on the containment fields, esp when they're otherwise "dumb" equipment and the emitters are the equipment with an ID lock on them. Making emitters get noisy when locked would also probably get people to start remembering to lock them, which is a bonus. |
It wouldn't be hard to change it to emitter yeah, wanna see what other people think first. Edit: I also realize giving the containment fields alarms was something part of the design doc here so I'd also be open to only doing it for the roundstart containment field gens, |
Going to try making it more inline with the design doc proposal. |
…tain amount, add item to give generators said component
…orderable by cargo, slightly better sprite
So I implemented the design doc version to the best of my ability. The difference from before is:
Current price for the crate is 2000 spesos (half of a single containment field x 4) Since there are concerns for how powerful this might be, I'm not changing any current generators on current maps, but I have made a crate with alarms and field gens with inbuilt alarms for mappers to add in if they want. |
Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this. |
Ready for this PR to thaw out of the freeze. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File-scoped namespaces as per standard.
As you've implemented this it might cause spam so might end up reverting it but will see in practice.
Content.Server/Singularity/EntitySystems/ContainmentAlarmSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/Singularity/EntitySystems/ContainmentFieldGeneratorSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/Singularity/EntitySystems/ContainmentFieldGeneratorSystem.cs
Outdated
Show resolved
Hide resolved
Content.Shared/Singularity/Components/ContainmentAlarmComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/Singularity/EntitySystems/ContainmentAlarmSystem.cs
Outdated
Show resolved
Hide resolved
Hey, sorry for the wait, we are currently quite backlogged with reviews.
|
Would removing/attaching require a tool or something? The idea was that it was impossible/very hard to remove. |
Make it only removable when they are offline, that way it can not be done to silently manipulate an active containment field, but you can still re-purpose it in case you want to use it somewhere else. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…on-14 into containment-annoucements
labels.mp4All changes should be in now |
…on-14 into containment-annoucements
I just want engi to get warned about anything that can round end the station. PA changed? Radio alert(fuck emag Borgs instantly killing the entire station by pressing a single button when no one is watching(I am that emagged Borg)). Power dying? Radio Alert(as AI I essentially have to do this 3 times a shift anyways). Containment field running on emergency power? Radio Alert(again fuck emag Borgs being able to doom the station(yes I've done this as well)). Containment Field dead? Radio alert(the station is fucked at this point anyways may as well give them some heads up). This seems like a step in the right direction 👍 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…on-14 into containment-annoucements
RobustToolbox is going to be the end of me again. Trying to fix it has once again broken something. Agggh. |
…on-14 into containment-annoucements
About the PR
Adds an item that when used on containment field generators makes them send messages over the engineering radio (or common when low) when a containment field is losing power or loses a connection because of power. They can be ordered from cargo.
Why / Balance
Gives engineering a heads up to either fix the problem or get everyone else to start running for their lives for one of the simpler ways to sabotage the tesla/singulo (cutting a few wires and waiting).
Implements part of this design doc.
This PR does not replace the current containment fields engineering starts with, but variants and crates with alarms are available for mapping in.
Technical details
Uses a new component that the field generator checks for and sends power data to to keep it updated. The component uses the radio and navmap systems to send messages about it's location.
Media
All.the.alarm.mov
Breaking changes
Hope not
Changelog
🆑