Fix ItemSlotSystem popup Logic

[aspiringLich]

About the PR

As far as I know, nobody has reported this, which is kinda surprising. I only got around to fixing it because of #28410, which I think got partially fixed and then wasn't closed?

Anyway, basically anything using ItemSlotSystem to handle insertion / removal of items, notably, chem dispensers and chem masters (don't know about this hapenning to anything else), were bugged, so they would constantly spit out "you can't put that in here!" popups whenever you inserted anything. This bug only happens if ItemSlotsComponent contains slots that have different whitelists.

This is because the popups were triggered at CanInsert per-slot, so if it failed the whitelist for even a single slot it would display the popup, even if the item could be inserted.

Technical details

• Removed the optional popup argument to CanInsert so the CanInsert method doesn't generate a popup (this was stupid to begin with)
• Changed the logic of OnInteractUsing so it triggers the popups instead, and also triggers them correctly

Media

2024-06-11.09-54-23.mp4

Breaking changes

Changelog

🆑

• fix: Fixed the logic triggering popups when inserting items into machines.

[aspiringLich]

I updated from master and I thought I saw that someone already fixed it. Nope it was just the popup message for a successful insertion which has always been there.

[metalgearsloth]

Having a big enum hardcoded like this defeats the purpose of the eventbus; I haven't had a chance to read the rest yet but this needs to go.

[aspiringLich]

I realised I am stupid and you don't need reason at all. I overcomplicated it way too much.

Events are also overkill.

[aspiringLich]

Oh also the other changes in the commit is because I formatted the file.

[Plykiya]

Added an overload method for CanInsert that doesnt have out var reason because optional out vars are not a thing in C# for some reason.

if you don't need the output variable you can just do out _

[aspiringLich]

I think I got rid of the overloaded method. Found a less turbo stupid way to do it.

[aspiringLich]

Updated the technical details comment

[ShadowCommander]

Does this properly show the WhitelistFailPopup if not all slots are locked but the last slot is not whitelisted?

[aspiringLich]

Wait, I just realized you'd want to show the locked popup if there's a slot that the item could go in, but the slot is locked. 

OKAY, so the logic goes like this:

• lastValidLockedSlot stores, if applicable, the last slot that should technically allow the item but is locked
• go through every single valid interactable slot
• if you can't insert the item,
  • if the item is allowed by the whitelist / blacklist, but the slot is locked, set lastValidLockedSlot
• if there are no slots that allow the item,
  • if lastValidLockedSlot is set, display the lockedFailPopup
  • otherwise, display the whitelistFailPopup
• otherwise, if there are valid slots
  • insert the item into the valid slot as normal

If none of the slots would have let the item in, it will display the whitelistFailPopup

If there was at least slot that (maybe) would have let it in if it wasnt locked, and there are no other valid slots, display lockedFailPopup.

I think it's correct now. I can't test it in game because, as far as I can tell, the only machine that takes advantage of the lockedFailPopup is the AME.

I did test it again on the reagent dispenser, and it seems to work so.

addressed