Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muffins #29318

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Muffins #29318

wants to merge 44 commits into from

Conversation

RumiTiger
Copy link
Contributor

@RumiTiger RumiTiger commented Jun 21, 2024

About the PR

I added a chocolate and banana muffin to the game. I also resprited the cherry and berry muffins.
I added recipes for almost all the muffins.
I added muffin tins to the game, they are used in muffin recipes. You can print them on the autolathe.

Why / Balance

I really don't understand why there were muffins in the game, but no way to make them.

Media

Muffins

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
🆑

  • add: A chocolate and banana muffin has been added to the game. The berry and cherry muffins have also been resprited!
  • tweak: Now you can make a regular, chocolate, banana, and berry muffin!
  • add: Muffin tins have been added to the game. They are needed for making muffins!

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

RSI Diff Bot; head commit 3eb0fc6 merging into d4da992
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Consumable/Food/Baked/misc.rsi

State Old New Status
muffin-berry Modified
muffin-cherry Modified
muffin-banana Added
muffin-chocolate Added

Resources/Textures/Objects/Consumable/Food/plates.rsi

State Old New Status
muffin-tin Added

Edit: diff updated after 3eb0fc6

@TheShuEd
Copy link
Member

webedit ops is real

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 17, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 23, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Aug 25, 2024

The test fail seems to be real. One of the problem is that the meta.json has the state cherry-muffin twice. If you get it fixed I can have a look at the PR. Also in the future, please avoid web edits so we can make sure all changes have been properly tested.

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Aug 29, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 1, 2024
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tested it in-game and everything works great. Found two more minor things that need to be adjusted. I will ask the art directors for approval of the sprites next.

@slarticodefast slarticodefast added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 1, 2024
RumiTiger and others added 2 commits September 2, 2024 03:52
…sc.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the cherry and chocolate cupcakes match the shading of the normal muffin, (with minor hue-shifting not just pure black/white) alongside making them more desaturated? If you wanted to, you could alternatively take aspects from the original cherry muffin sprite and put it onto the normal muffin for consistency.

@RumiTiger
Copy link
Contributor Author

Could you make the cherry and chocolate cupcakes match the shading of the normal muffin, (with minor hue-shifting not just pure black/white) alongside making them more desaturated? If you wanted to, you could alternatively take aspects from the original cherry muffin sprite and put it onto the normal muffin for consistency.

Like this?
Muffins

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 16, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Sep 16, 2024

Also in the future, please avoid web edits so we can make sure all changes have been properly tested.

Like I asked before, please avoid webedits and push changes to your remote branch using git instead for the following reasons:

  • webedits are more susceptible to errors since you may forget to upload a file or submit a wrong one
  • webedits frequently cause issues with wrong whitespace in text files
  • we cannot ensure the changes have been locally tested by the author like they should be
  • each single commit causes the integration tests to be re-run and there is a total computation limit

Please refer to our documentation to learn how to use git and an IDE:
Git for the SS14 Developer
Setting up a Development Environment

Like this?

I will ask the art directors for approval.

@RumiTiger
Copy link
Contributor Author

Some day…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants