-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clumsy system refactor #31147
base: master
Are you sure you want to change the base?
Clumsy system refactor #31147
Conversation
OK looks like I forgot that tables made a special sound 😭 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I guess I'll give this a look since it's kind of blocking gun executions as well? |
If you need me to make any changes that would make the gun executions easier, just let me know and I can do em! |
Ooh... this makes it possible to make a system that would block hyposprays from injecting through hardsuits, for example, if I read this right. I like this! And yay removing unrelated fields from components. |
Hopefully that's better! The defib system in general is very confusing... |
Content.Server/Administration/Systems/AdminVerbSystem.Smites.cs
Outdated
Show resolved
Hide resolved
OK think I fixed all that! Let me know if you need anything else or if I missed something 🫡 |
About the PR
The clumsy system was just hard coded into a lot of places. Now the clumsy system uses events that it can interact with instead!
Technical details
As above, I mostly just made events where there weren't before and made the clumsy system hook into them and listen and interact with them. Specifically, the gun system, defib system, hypospray system, and climb on thing system.
Media
2024-08-17.20-46-35.mp4
Requirements
Breaking changes
If you hard coded clumsy stuff into important systems please trigger events and listen for them in the clumsy system now!
Changelog
🆑 Beck Thompson