Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tape recorder v3 revival #32234

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Sep 17, 2024

About the PR

revival of #30089
refactored, microoptimised and addressing reviews
changed the weird dual-state thing to just be mode and thats it

stores the verb used, but the exact string the server picked in SendEntitySpeak can't be saved. presumably this will be possible in chat refactor, then the tape can store the exact message (including whispering, which still isnt stored right)

Why / Balance

see old pr

Technical details

Active bool changed to ActiveTapeRecorder so it can be queried for
UI uses RadioOptions instead of making them manually
most of the state is just gotten from the component instead of being sent in every bui state
it also stores the used speech verb now

Media

Pause | Record | Playback | Rewind
03:52:14

03:52:19

03:52:29

03:58:55

03:59:52

it will use a random string from the speech verb that was recorded
04:58:25

Requirements

Breaking changes

no

Changelog
🆑 BombasterDS, deltanedas

  • add: Tape recorders and cassettes can now be crafted in autolathes for recording crew speech.

@github-actions github-actions bot added Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

RSI Diff Bot; head commit 00b13ea merging into 338781c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/cassette_tapes.rsi

State Old New Status
tape_greyscale Added
tape_ribbonoverlay Added

Resources/Textures/Objects/Devices/tape_recorder.rsi

State Old New Status
inhand-left Added
inhand-right Added
taperecorder_empty Added
taperecorder_idle Added
taperecorder_playing Added
taperecorder_recording Added
taperecorder_rewinding Added

Resources/Textures/Objects/Storage/boxes.rsi

State Old New Status
recorder Added

Edit: diff updated after 00b13ea

@lzk228
Copy link
Contributor

lzk228 commented Sep 17, 2024

he is cooking 🗣️🗣️🗣️

@MemesHodachy
Copy link

let him cook dat 🔥

@deltanedas
Copy link
Contributor Author

deltanedas commented Sep 17, 2024

the whisper stuff from #17898 needs to be fixed with a chat refactor, right now if i want to have it i would need to copy paste all of its logic to hide identity in the transcript

same thing but worse for getting the exact verb that was used

@deltanedas deltanedas marked this pull request as ready for review September 17, 2024 15:59
@beck-thompson
Copy link
Contributor

Fourth times the charm! Good luck 🫡

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@slarticodefast
Copy link
Member

Will need to be adjusted for #30798

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 18, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants