-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tape recorder v3 revival #32234
base: master
Are you sure you want to change the base?
tape recorder v3 revival #32234
Conversation
NOW WITH UI
…e-station-14 into newtaperecorder
RSI Diff Bot; head commit 00b13ea merging into 338781c Resources/Textures/Objects/Devices/cassette_tapes.rsi
Resources/Textures/Objects/Devices/tape_recorder.rsi
|
he is cooking 🗣️🗣️🗣️ |
let him cook dat 🔥 |
the whisper stuff from #17898 needs to be fixed with a chat refactor, right now if i want to have it i would need to copy paste all of its logic to hide identity in the transcript same thing but worse for getting the exact verb that was used |
Fourth times the charm! Good luck 🫡 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Will need to be adjusted for #30798 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
revival of #30089
refactored, microoptimised and addressing reviews
changed the weird dual-state thing to just be mode and thats it
stores the verb used, but the exact string the server picked in SendEntitySpeak can't be saved. presumably this will be possible in chat refactor, then the tape can store the exact message (including whispering, which still isnt stored right)
Why / Balance
see old pr
Technical details
Active bool changed to ActiveTapeRecorder so it can be queried for
UI uses RadioOptions instead of making them manually
most of the state is just gotten from the component instead of being sent in every bui state
it also stores the used speech verb now
Media
Pause | Record | Playback | Rewind
it will use a random string from the speech verb that was recorded
Requirements
Breaking changes
no
Changelog
🆑 BombasterDS, deltanedas