Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Towels #32235

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Add Towels #32235

merged 8 commits into from
Oct 18, 2024

Conversation

IProduceWidgets
Copy link
Contributor

About the PR

image

Department color towels are also included as department/role long-term playtime trinkets.

Why / Balance

A towel has immense psychological value. For some reason, if a strag (strag: nonhitchhiker) discovers that a hitchhiker has his towel with him, he will automatically assume that he is also in possession of a toothbrush, washcloth, soap, tin of biscuits, flask, compass, map, ball of string, gnat spray, wet-weather gear, space suit etc., etc. Furthermore, the strag will then happily lend the hitchhiker any of these or a dozen other items that the hitchhiker might accidentally have "lost". What the strag will think is that any man who can hitch the length and breadth of the galaxy, rough it, slum it, struggle against terrible odds, win through, and still knows where his towel is, is clearly a man to be reckoned with.

Technical details

Media

Requirements

Breaking changes

Changelog

  • add: Towels may now be brought with experienced crewmembers.

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

RSI Diff Bot; head commit f5c4165 merging into 5eaac00
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Multiple/towel.rsi

State Old New Status
NTmono Added
equipped-BELT Added
equipped-HELMET Added
equipped-INNERCLOTHING Added
icon Added
iconstripe Added
inhand-left Added
inhand-right Added

Edit: diff updated after f5c4165

@Djungelskog2
Copy link

you should make them be able to be worn on your head

@Djungelskog2
Copy link

nevermind im fucking blind

@IProduceWidgets
Copy link
Contributor Author

you should make them be able to be worn on your head

Did do. Unfortunately due to a limitation I cant make them hide hair however.

@slarticodefast
Copy link
Member

There's a frood who really knows where his towel is.

@UbaserB
Copy link
Member

UbaserB commented Sep 17, 2024

This is so silly omg

@GoldenCan
Copy link
Contributor

Wow.
Wow.

Finally someone decided to PR this. I have tried to make some sprites myself but they were rather terrible.

Being able to equip towels in so many different regions really sells the idea of their multipurposeness, but i wish these could be used like to clean up minor spills like a bar rag, or that they could be worn over the eyes like a blindfold.

Regardless, this is a fanastic PR! The sprites look great and the towel can be worn in all the places where it would be expected.

@ps3moira
Copy link
Contributor

ps3moira commented Sep 17, 2024

Would it be possible to wear the towel on the shoulders too? Using the neck slot

@deltanedas
Copy link
Contributor

towel from zomboid from cdda from hitchhikers guide

@august-sun
Copy link
Contributor

Wow. Wow.

Finally someone decided to PR this. I have tried to make some sprites myself but they were rather terrible.

Being able to equip towels in so many different regions really sells the idea of their multipurposeness, but i wish these could be used like to clean up minor spills like a bar rag, or that they could be worn over the eyes like a blindfold.

Regardless, this is a fanastic PR! The sprites look great and the towel can be worn in all the places where it would be expected.

BIG seconded to being used for cleanup purposes, would be really helpful for folks to help clean messes in a pinch.

@slarticodefast
Copy link
Member

but i wish these could be used like to clean up minor spills like a bar rag

I agree and they could probably completely replace the rag, since the rag sprite looks weird #25051

@Golinth
Copy link
Contributor

Golinth commented Sep 20, 2024

Would it be possible to wear the towel on the shoulders too? Using the neck slot

Seconding this. I wanna drape it across my shoulders like the pic

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 23, 2024
@slarticodefast slarticodefast added the PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. label Oct 4, 2024
@slarticodefast
Copy link
Member

Tested in-game and everything works as intended. Should be good to merge.

@slarticodefast slarticodefast self-assigned this Oct 4, 2024
@chromiumboy
Copy link
Contributor

Awesome, looks good to me

@slarticodefast
Copy link
Member

We can give the high unlock times a try and see what the players think of them. If neccessary, we can always lower them later.
But I think it is fine considering it is only a visual color change. And it serves as a fun loyalty item for experienced players that also encourages you to try out other departments more.

@slarticodefast slarticodefast merged commit 091e4c1 into space-wizards:master Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.