Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsQueuedForDeletion checks to interaction system #32526

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ElectroJr
Copy link
Member

About the PR

Attempts to prevent multiple simultaneous interactions from using an entity despite it being queued for deletion

Why / Balance

Prevents some bugs, like the one fixed by #32524

Technical details

Basically just adds a bunch of TerminatingOrDeleted() and IsQueuedForDeletion() checks

@metalgearsloth metalgearsloth merged commit 97f6097 into space-wizards:master Oct 14, 2024
12 checks passed
@slarticodefast
Copy link
Member

slarticodefast commented Oct 14, 2024

@metalgearsloth @ElectroJr
This PR causes debug asserts to happen if you click on things or the player.
See #32811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants