Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syndie satchel, buff syndie backpack, abstract bag parents #32713

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Plykiya
Copy link
Contributor

@Plykiya Plykiya commented Oct 9, 2024

About the PR

  • Adds the syndicate satchel to the game since syndies already had backpacks and duffels (sprite by Dutch-VanDerLinde). It is explosion-resistant and one row larger than a regular satchel.
  • Buffs the syndicate backpack storage by one column to give it an additional benefit like the duffelbag.
  • Adds a missing description to the syndicate backpack.
  • Created base abstract parents for the backpack, satchel, and duffelbag and change all relevant bags to use these abstract parents instead of being parented off of the default backpack.

Satchels from #27398

image

Why / Balance

Syndie satchels are necessary for my drip game and it's odd we don't have them yet.

Technical details

Abstract parents are needed for the different bag types because it's just good practice to not parent off of used entities, someone might make a change to backpacks thinking it only affects backpacks and it cascades to all 3 bag types in the game.

I thought about changing the Id of all the bags to reflect the new parent base since every id currently has "Backpack" in the name but decided it would be way too disruptive of a change for no reason.

Parenting changes:

  • ClothingBackpack -> ClothingBagBackpackBase
  • ClothingBackpackDuffel -> ClothingBagDuffelBase
  • ClothingBackpackSatchel -> ClothingBagSatchelBase

Media

2024-10-09.01-40-36.mp4

Requirements

Breaking changes

Changelog

🆑

  • add: The syndicate satchel is now available for purchase in the uplink.

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

RSI Diff Bot; head commit 9e36c86 merging into 357e998
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Back/Satchels/syndicate.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 9e36c86

@bruhmogus
Copy link

YES. YES. YES. SYNDRIP IS A NECESSARY FEATURE

Copy link
Contributor

@Centronias Centronias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not like I'm not guilty of doing this all the time, but mixing the abstract bag parents changes with syndicate bag changes makes this a bit slower to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants