Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reagent Description for Bananium #32810

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix Reagent Description for Bananium #32810

merged 2 commits into from
Oct 17, 2024

Conversation

scrivoy
Copy link
Contributor

@scrivoy scrivoy commented Oct 14, 2024 •
edited
Loading

About the PR

Why / Balance

  • It's not radioactive anymore.
  • It doesn't exist, gets juiced into honk instead.

Technical details

  • Changed to A yellow organic solid.
  • deleted ftl strings

Media

Requirements

Breaking changes

Changelog

@scrivoy
Copy link
Contributor Author

scrivoy commented Oct 14, 2024

Can't provide a Screenshot.
Maybe im just too new to find the matching Prototype in the Code or its really not there yet?
For my understanding it must be in this File, right?

space-station-14/Resources/Prototypes/Reagents/elements.yml

Line 1 in f5ab4f5

- type: reagent

@github-actions github-actions bot added the No C# For things that don't need code. label Oct 14, 2024
@slarticodefast slarticodefast self-assigned this Oct 14, 2024
@slarticodefast slarticodefast added PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. and removed PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. labels Oct 14, 2024
@slarticodefast
Copy link
Member

Oh, wait, looks like you are right. That ftl string is not used anywhere it seems since bananium does not have its own reagent but gets juiced into honk instead.
In that case, could you simply remove the name and description string?

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Oct 14, 2024
@scrivoy
Copy link
Contributor Author

scrivoy commented Oct 14, 2024

could you simply remove the name and description string?

okay its removed

@slarticodefast
Copy link
Member

Thanks!

@slarticodefast slarticodefast added PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 14, 2024
@chromiumboy
Copy link
Contributor

Thank you for your contribution. I had a look and it doesn't seem like the removed strings are needed anymore

@chromiumboy chromiumboy merged commit 0bee22e into space-wizards:master Oct 17, 2024
10 checks passed
@scrivoy scrivoy deleted the fix-desc-bananium-reagent branch October 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
No C# For things that don't need code. PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bananium reagent still references it being radioactive
3 participants
@scrivoy @slarticodefast @chromiumboy