Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Anomaly Core Functionality Overhaul, Pt. 1 #32839

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

august-sun
Copy link
Contributor

@august-sun august-sun commented Oct 16, 2024

About the PR

Gave each inert anomaly core a minimum added function appropriate for their type. These provide primarily utility-based benefits, with some being more specialized than others.

Pyro Core: A core that acts as a lesser experimental welder. 500u container, recharges at half the speed, cannot be refilled externally. Has a different in-hand state for when it's lit.

Gravity Core: Can neutralize a mid-size singularity or tesla when absorbed. Highly specialized purpose, but very powerful.

Electricity Core: Acts as a microreactor battery. Cannot be charged in a cell recharger.

Ice Core: Slips people, can make ice walls after a 30 second doAfter.

Rock Core: Acts as a miniature wielded pickaxe single-handed, with same structural damage. Pocket pickaxe!

Meat Core: Can be microwaved to create an anomalous meat mass, a giant steak that can be cooked and eaten individually, or cut into 10 steaks.

Liquid Core: Pocket size jug. Does not spill when thrown. Must be filled from other containers.

Bluespace Core: 3x3 box. Can fit up to medium items.

Shadow Core: 5 minute long CD reusable mini smoke grenade.

Tech Core: 5 minute long CD, single-charge emag.

Why / Balance

Currently, anomaly cores have very limited function. This gives each of them a unique feature that is beneficial to a user, as well as appropriate for the element of the anomaly. While some of these can cause trouble in the wrong hands, these arguably add more than enough intrigue that ideally offsets the risks they may pose.

Technical details

Most YAML changes made to the cores draw components from items they act similar to, with only certain items inheriting parentage. While this extends the length of the descriptors, it avoids any unnecessary component complications or additions. This adds a description for each of the inert cores as well.

Sprites were added for new items (namely the anomalous meat mass and cooked version) and the added item state (the lit version of the pyro core welder).

A new component and system were made for the SmokeOnUse effect, allowing the shadow core to be used in-hand, adapted nearly identically from the SmokeOnTrigger system.

Media

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Added a wide range of new, unique uses for each inert anomaly core.
  • add: Added new entity sprite states for new anomaly core functions.
  • add: Added new anomaly-specific food.

@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

RSI Diff Bot; head commit cb74399 merging into 7e0e641
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Consumable/Food/meat.rsi

State Old New Status
anomalymeat-cooked Added
anomalymeat Added

Resources/Textures/Structures/Specific/Anomalies/Cores/pyro_core.rsi

State Old New Status
litcore Added

Edit: diff updated after cb74399

@DieselMohawk
Copy link
Contributor

One thing I noticed off the rip, for the meta.json file for the anomaly meat, you accidentally left "rouny meat cooked." That's probably causing an error.

@august-sun
Copy link
Contributor Author

One thing I noticed off the rip, for the meta.json file for the anomaly meat, you accidentally left "rouny meat cooked." That's probably causing an error.

Thanks, it's late and I at least wanted to get the uhhh proverbial meat of the PR out there. Will clean this up tomorrow!

@DieselMohawk
Copy link
Contributor

One thing I noticed off the rip, for the meta.json file for the anomaly meat, you accidentally left "rouny meat cooked." That's probably causing an error.

Thanks, it's late and I at least wanted to get the uhhh proverbial meat of the PR out there. Will clean this up tomorrow!

All good, sleep well

@Cojoke-dot
Copy link
Contributor

Great pr, I love the idea of cores doing more. I think the tech anom one is an issue though, too many shifts of non-antag sci making lasers and arming without any contraband. You essentially have a 1x1 item sec can't take from you without provocation that servers the same function as an 8tc item, it being a little slower is not going to affect much.

@Krovotushka
Copy link

Science would eat so good they become obese, also what about plant anomaly?

@DieselMohawk
Copy link
Contributor

Science would eat so good they become obese, also what about plant anomaly?

I believe a PR passed already that turned them into seeds

@august-sun
Copy link
Contributor Author

Great pr, I love the idea of cores doing more. I think the tech anom one is an issue though, too many shifts of non-antag sci making lasers and arming without any contraband. You essentially have a 1x1 item sec can't take from you without provocation that servers the same function as an 8tc item, it being a little slower is not going to affect much.

If it's not labeled as contraband, it was intended to be, apologies!

@Boaz1111
Copy link
Contributor

It still says the card zaps something in the airlock instead of something specifically for the core

@SoulFN
Copy link
Contributor

SoulFN commented Oct 16, 2024

I think this functionality should be moved to separate devices that are studied in the experimental tree (T2 or T3 technologies) and they require anomaly cores.

@august-sun
Copy link
Contributor Author

It still says the card zaps something in the airlock instead of something specifically for the core

I noticed this as well, however the only change I could think of that made any sense was changing the string to "the DEVICE zaps something", otherwise afaik it would take messing with the system in a way that wouldn't be worth it, for such a small detail. If that can be redefined in YAML, I'm all ears!

@Everturning
Copy link

these are really fucking OP holy shit
I am against these
there is no downside to any of them

@ultramario1998
Copy link

ultramario1998 commented Oct 16, 2024

A couple things:

Gravity Core: I'm conflicted about this. Coming from a server where the ONLY time we see the singularity is on Core, this feels pretty OP, but I don't know if it'd actually turn out that way. I would LOVE a storyline involving a heroic scientist sacrificing themselves to the tesla so everyone else could live, but I could see Science just handing these cores to Engineering, which a tesla would eat first anyways (and then stop because an engineer threw the core in, or it was just sitting next to a SMES that it's headed to eat). Regardless, I feel that even if people are using this in a meta way, any loose is going to result in evac no matter what -- you're just leaving a half-destroyed station instead of a fully-destroyed one.

Meat Core: fucking love this. we need more interactions with the kitchen

Tech Core: I almost think that the CD on this should be longer by a couple minutes, although I'd like to test it out in a real round before making this call for sure

these are really fucking OP holy shit I am against these there is no downside to any of them

The downside is a) the very VERY long cooldown on some of these, b) which anomalies spawn is completely random, so fishing for the tech anom is probably going to require spawning several in the first place (which is suspicious behavior even without this PR being merged), and c) science will only ever get a handful of cores by round end at most, because they're encouraged to keep anomalies around for points. You're never going to have roundstart scientists handing out electric cores for greytiders' flashlights.

@august-sun
Copy link
Contributor Author

A couple things:

Gravity Core: I'm conflicted about this. Coming from a server where the ONLY time we see the singularity is on Core, this feels pretty OP, but I don't know if it'd actually turn out that way. I would LOVE a storyline involving a heroic scientist sacrificing themselves to the tesla so everyone else could live, but I could see Science just handing these cores to Engineering, which a tesla would eat first anyways (and then stop because an engineer threw the core in, or it was just sitting next to a SMES that it's headed to eat). Regardless, I feel that even if people are using this in a meta way, any loose is going to result in evac no matter what -- you're just leaving a half-destroyed station instead of a fully-destroyed one.

Meat Core: fucking love this. we need more interactions with the kitchen

Tech Core: I almost think that the CD on this should be longer by a couple minutes, although I'd like to test it out in a real round before making this call for sure

these are really fucking OP holy shit I am against these there is no downside to any of them

The downside is a) the very VERY long cooldown on some of these, b) which anomalies spawn is completely random, so fishing for the tech anom is probably going to require spawning several in the first place (which is suspicious behavior even without this PR being merged), and c) science will only ever get a handful of cores by round end at most, because they're encouraged to keep anomalies around for points. You're never going to have roundstart scientists handing out electric cores for greytiders' flashlights.

Appreciate the feedback here! And yeah, the cores are intended to be unique and useful tools without having a TON of abuse implemented. I have gotten feedback about the Tech Core potentially causing a bit too much trouble, my current alternative is creating a solution that does the same thing for machines that lube does, and making the anomaly generate said solution (which would be its ONLY purpose, it would not behave like lube).

Additionally, currently, the Bluespace Core is currently failing the integration test, so I'm exploring alternatives for that, as well!

@Cojoke-dot
Copy link
Contributor

Great pr, I love the idea of cores doing more. I think the tech anom one is an issue though, too many shifts of non-antag sci making lasers and arming without any contraband. You essentially have a 1x1 item sec can't take from you without provocation that servers the same function as an 8tc item, it being a little slower is not going to affect much.

If it's not labeled as contraband, it was intended to be, apologies!

meh, it would still give a massive load on sec because a sci member took the core and emaged the proto-lathe so now all the tiders have lasers. Even if sec searched every sci they can hide the core in one large space, so plushies, G.O.R.I.L.A gauntlets, top hats, and lots of places sec would never check and just cause some sci who is a non-antag to emag the lathe. It would either end up with more people getting banned for emaging the lathe and handing out guns as a non-antag and/or a much greater strain on sec due to sci constantly making weapons, forcing them to destroy the rd server to prevent the production of more. idk, I don't see how this item is not just going to be abused to make sec shifts worse.

@Kandiyaki
Copy link

this is a REALLY cool idea, but I feel like it's too much to be able to get these effects near-roundstart. I'd say a good balance would be to make a new "harnesser" item that you can load cores into, which causes these effects based on the type loaded in, locked behind the same tech as the GORILLA gauntlet. this would:

  • make it easy-ish to get the item, since anomaly core harnessing is a tier 1
  • make it so these effects aren't just a free reward for taking down anomalies
  • make the anomaly core harnessing tech finally have multiple uses
  • make it so you need access to a protolathe in order to use the cores (tider repellent)
  • make it so you don't have to mark the cores as science contraband, just the harnesser
  • make it easy to give the harnesser a limited amount of charges per core in case of balance issues

could be implemented decently easily by just modifying the GORILLA gauntlet code, i think

@LankLTE LankLTE added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Oct 16, 2024
@deltanedas
Copy link
Contributor

tech anomaly core being an emag would go so hard for making free borgs

@EthanQix
Copy link

I think this is a great idea, though I'd modify two cores :

  • Grav core : the anti singulo effect is too situational to be really useful. Maybe make it a tiny grav gun instead ?
  • Tech core : a mini emag for 0TC is OP no matter how you look at it, not to mention it could encourage shitter behavior. It shouldn't recharge at all.

@august-sun
Copy link
Contributor Author

this is a REALLY cool idea, but I feel like it's too much to be able to get these effects near-roundstart. I'd say a good balance would be to make a new "harnesser" item that you can load cores into, which causes these effects based on the type loaded in, locked behind the same tech as the GORILLA gauntlet. this would:

* make it easy-ish to get the item, since anomaly core harnessing is a tier 1

* make it so these effects aren't just a free reward for taking down anomalies

* make the anomaly core harnessing tech finally have multiple uses

* make it so you need access to a protolathe in order to use the cores (tider repellent)

* make it so you don't have to mark the cores as science contraband, just the harnesser

* make it easy to give the harnesser a limited amount of charges per core in case of balance issues

could be implemented decently easily by just modifying the GORILLA gauntlet code, i think

So, the point mario made earlier regarding the aim of keeping anomalies alive early on is a key one. Yeah, you might get a cool object out of it if you kill the anomaly, but you've also just shut down one of the early, steady ways you have to generate points. There's incentive to keep anomalies stabilized at least initially for that sake.

Additionally, the cores aren't intended to be a science-only item, it's to give departments throughout the station useful interaction with the cores. Some are more specific, some are more general. The size of the object also comes into play, as putting them in a gauntlet kind of neutralizes that benefit.

Like others have said around the emag, I realize how much of a problem that has the potential to cause, so I'm looking at alternatives for it (like the previous mention of making it auto-generate a solution exclusively for speeding up machines).

@UncaughtEx
Copy link

Perhaps the tech anom core can wipe a borgs laws completely

@UBlueberry
Copy link
Contributor

i think tech core = emag is a little busted, especially because the emag is a syndie item that gives access to syndie material
what if it were more like the ninja glove emag (airlocks only, basically)?

@UncaughtEx
Copy link

A way to completely wipe borg laws and make free borgs would be fun

@Salinarin
Copy link

Tech anom core as an EMAG is too strange. Maybe make it a remote signaller with unlimited range or a door remote with random accesses?

Copy link
Contributor

@LankLTE LankLTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these having some side effect is cool, their primary use is to power the GORILLA and it should stay that way. The meat, liquid & bluespace cores manages to strike a nice balance of being a simple neat side effect you can use them for, but almost all of the others are far too strong (tech, gravity, and electricity), or far too weak (ice, shadow). If that was sorted out and they were redone to be more middling effects I think this could be reconsidered but as-is this won't be merged.

@WhiteGorila
Copy link

Lots of bitching and moaning in the comments dispite the 24 likes, the game needs more fun in it

@Djungelskog2
Copy link

Lots of bitching and moaning in the comments dispite the 24 likes, the game needs more fun in it

The game would be more fun if everyone got .35 pistols in their emergency boxes and 2 mags to go along with it round start
Or is fun subjective

@WhiteGorila
Copy link

Lots of bitching and moaning in the comments dispite the 24 likes, the game needs more fun in it

The game would be more fun if everyone got .35 pistols in their emergency boxes and 2 mags to go along with it round start Or is fun subjective

That would be in the more fun category

@Djungelskog2
Copy link

Lots of bitching and moaning in the comments dispite the 24 likes, the game needs more fun in it

The game would be more fun if everyone got .35 pistols in their emergency boxes and 2 mags to go along with it round start Or is fun subjective

That would be in the more fun category

WYCI? :godo:

@Spessmann
Copy link
Contributor

Make this only apply to cores from supercritical anomalies so the regular ones still have use with gorilla gauntlets :trollface:

@insoPL
Copy link
Contributor

insoPL commented Oct 22, 2024

this is a REALLY cool idea, but I feel like it's too much to be able to get these effects near-roundstart. I'd say a good balance would be to make a new "harnesser" item that you can load cores into, which causes these effects based on the type loaded in, locked behind the same tech as the GORILLA gauntlet. this would:

  • make it easy-ish to get the item, since anomaly core harnessing is a tier 1
  • make it so these effects aren't just a free reward for taking down anomalies
  • make the anomaly core harnessing tech finally have multiple uses
  • make it so you need access to a protolathe in order to use the cores (tider repellent)
  • make it so you don't have to mark the cores as science contraband, just the harnesser
  • make it easy to give the harnesser a limited amount of charges per core in case of balance issues

could be implemented decently easily by just modifying the GORILLA gauntlet code, i think

Making universal item that transform into anomaly core specific item, then marking some of them as contraband would make more sense. Would also make mining with core look less goofy.

@superjj18
Copy link
Contributor

superjj18 commented Oct 22, 2024

singulooses and teslooses are cringe 👍 #BuffTheDecelerator

@strO0pwafel
Copy link
Contributor

ideaguying
gravity: weightless pulling
ice: removes firestacks
electricity: defib

@august-sun
Copy link
Contributor Author

singulooses and teslooses are cringe 👍 #BuffTheDecelerator

Super agreed, I might PR this one.

@august-sun
Copy link
Contributor Author

ideaguying gravity: weightless pulling ice: removes firestacks electricity: defib

Per Lank's feedback, removing firestacks and defib might be too strong; at the moment, looking at converting the electricity one to a large battery equivalent, and for ice, making an ice crust floor with a 2 second doafter. Ice is one of those that's tricky to find an okay use for, and I think that'll be good enough for the potential novelty's sake without being too OP or in the way.

@HyperB1
Copy link

HyperB1 commented Oct 22, 2024

Tech core would be better off having multitool functionality.

@superjj18
Copy link
Contributor

superjj18 commented Oct 22, 2024

Tech core would be better off having multitool functionality.

That's lame af, mini-emag is infinitely cooler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.