Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL interaction event broadcasting to container #32841

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Alwayswannahunt
Copy link

@Alwayswannahunt Alwayswannahunt commented Oct 16, 2024

About the PR

Added System to broadcast interaction events to entities in containers and from entities in container
I used it to make a ninja headset which can copy encryption keys from other headsets or keys. But component of copying exists only on key.
Similar thing were made for a agent id card: now you can copy accesses from a pda with id or by interaction with pda or id card by the pda with agent card.
Look media to see how it works.

ToDo things:

  • Think once again about broadcast interaction system/component naming (its really weird, I know)
  • Gather admin logs from system together

Why / Balance

This reduce minor grief of stealing headsets or throwing out someone's id while using agent card.
About copying by PDA with agent ID. I made it just to check if system of broadcasting works correct with events from entity in container to another entity in container. Its only a suggestion and can be removed besides without it wont be less changes.

Technical details

Added 3 components each one is responsible for broadcast interaction event in different stages of interaction.
Added System which copy channels from keys/headsets.
Moved AgentIDCardComponent to shared due to prediction issue
Added method to EncryptionKeySystem which adds channels to key
Changed event methods to use Entity, because I used them.

Media

qol_pr_compress.mp4

Requirements

Breaking changes

Added 3 components each one is responsible for broadcast interaction event in different stages of interaction. Also comes with interaction from container/ to container events! Highly recommend to use included whitelist/blacklist to prevent making too much events.
Moved AgentIDCardComponent to Shared.
Added System/Component which can copy channels from headsets/encryption keys

Changelog
🆑 AlwyAnri, Stalengd

  • add: Ninja headset which can copy channels!
  • tweak: Agent ID can copy accesses from PDAs
  • tweak: PDA with Agent ID can copy accesses from PDAs/IDs

@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

RSI Diff Bot; head commit 728554f merging into 81a8646
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Ears/Headsets/ninja.rsi

State Old New Status
equipped-EARS Added
icon Added

Resources/Textures/Objects/Devices/encryption_keys.rsi

State Old New Status
crypt_green Added
spider_label Added

Edit: diff updated after 728554f

@Alwayswannahunt Alwayswannahunt changed the title QoL event broadcasting to container QoL interaction event broadcasting to container Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant