Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JumpBoots #32861

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

JumpBoots #32861

wants to merge 15 commits into from

Conversation

Jopaglazik
Copy link

@Jopaglazik Jopaglazik commented Oct 17, 2024

About the PR

Added Jump Boots game allowing you to jump over various floor obstacles. Also added crafting and their research in T2 industrial technology “Mass Excavation”

Why / Balance

Needed for salvagers when exploring wrecks/asteroids/expeds to overcome obstacles or for mobile introduction of combat. Maybe in the future someone will make wrecks presets with places that can't be reached without these boots.

Technical details

The code may be shit because it's my first experience in development idk

In addition to adding a component for clothing, I left the option to add an Action to a character (maybe someone could use it for some abilities with a jump etc.)
From the problems: hardcoded ability cooldown; jump distance is calculated only by JumpPower variable in the component, to enter a variable for the exact distance in the tiles did not work.

Media

2024-10-17.12-59-43.mp4

Requirements

Breaking changes

Changelog

🆑 Jopaglazik

  • add: Added Jump Boots In T2 "Mass Excavation" technology.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

RSI Diff Bot; head commit a8dea66 merging into b3c6153
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Shoes/Boots/jumpboots.rsi

State Old New Status
equipped-FEET-vox Added
equipped-FEET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Interface/Actions/jump.rsi

State Old New Status
icon Added

Edit: diff updated after a8dea66

@Jopaglazik
Copy link
Author

No idea how to fix checks HEЕЕЕLP
whats wrong with it?

@Boaz1111
Copy link
Contributor

I’ll have a look

@Boaz1111
Copy link
Contributor

@Jopaglazik it can’t seem to find Textures/Clothing/Shoes/Boots/jumpboots.rsi
Something like that, I checked the file, don’t immediately see anything wrong

@Boaz1111
Copy link
Contributor

Try removing line 160 and 161 from Resources/Prototypes/Entities/Clothing/Shoes/misc.yml. Those are most likely causing your test fail.

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool idea.
Quick partial review, I did not look at all the code yet.
Also the yaml linter is failing, something else must be wrong in your yaml file causing the .rsi loading error.

Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
Textures/Clothing/Shoes/Boots/jumpboots.rsi/meta.json Outdated Show resolved Hide resolved
Textures/Interface/Actions/jump.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Audio/Effects/attributions.yml Show resolved Hide resolved
Resources/Prototypes/Actions/types.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Clothing/Shoes/misc.yml Outdated Show resolved Hide resolved
Jopaglazik and others added 3 commits October 17, 2024 15:09
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
@Kadeo64
Copy link
Contributor

Kadeo64 commented Oct 17, 2024

looks like the 'throwing' animation is bugged in the preview, I hope that gets fixed before release

@Boaz1111
Copy link
Contributor

Very cool idea. Quick partial review, I did not look at all the code yet. Also the yaml linter is failing, something else must be wrong in your yaml file causing the .rsi loading error.

Probably those lines I mentioned, right?

Jopaglazik and others added 3 commits October 17, 2024 15:34
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
@Jopaglazik
Copy link
Author

Probably those lines I mentioned, right?

No, I put textures in wrong folder =)

@Kupperoid
Copy link

That's a great idea

I wish you success in your endeavors :)

Resources/Audio/Effects/attributions.yml Outdated Show resolved Hide resolved
Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
Content.Shared/Movement/Components/JumpComponent.cs Outdated Show resolved Hide resolved
@metalgearsloth metalgearsloth added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Oct 17, 2024
@ps3moira
Copy link
Contributor

ps3moira commented Oct 17, 2024

can it jump over pits?

@Jopaglazik
Copy link
Author

can it jump over pits?

yeap

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants