-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Wield To Activate Double-bladed ESword #32869
base: master
Are you sure you want to change the base?
Conversation
Hopefully this doesnt break the syndie assault borg's esword? |
I tested both, and this does not affect the [one handed] variant that the borgs use, so they may continue to one "hand" their swords |
I have realized that the double bladed esword is more broken than I had originally thought. If you enable it on the floor and then pick it up, you can no longer attack with it, but the model is broken as it pairs the wielded blades with the unwielded handle. Looks like I will have to turn it off on pickup |
This change also prevents people from attacking with it when it is unpowered as well, so I am going to have to look into degerming if it is powered on or off |
Some of this is fixed in the hypereutactic blade PR, so you can lift some of the fixes from that |
I have modified how I've gone about this Initially I had added the
The route i have gone now, is adding the parameter
However, this has the pros of:
|
MeleeRequiresWield works for this. |
This does prevent the user from attacking with the weapon in one hand, which is part of the issue, but it does not take into account if the weapon is activated or not. So if someone wants to hit someone with the blades disabled, it prevents them. This would also require new sprites, as the Dsword does not have a sprite for an unwielded blade, only an unwielded handle and wielded blades. The main issue with allowing it to be used in one hand is the high reflect chance. If you have it in one hand, you still have the benefit of the 75% reflect chance, which is balanced under the assumption that it will only be held in both hands. In comparison to the eshield it has a lower reflect chance, but it also doesn't burn out and provides a constant reflection bonus. In my implementation, it prevents the dsword not only from attacking with one hand, but it also prevents it from providing its above average reflection chance when it isn't supposed to. |
About the PR
Despite being balanced around being wielded, the double-bladed esword could be swung using only one hand if activated on the ground and then picked up. Now, the double-bladed esword can only be activated by wielding it, and can not be activated on the ground. This means that throwing it, putting it down, or dropping it turns the blade off.
Why / Balance
Fixes #32772 and enforces intended weapon balancing.
Technical details
Add
onActivate: false
component to the double esword, preventing it from being activated outside of the user wielding it.Requirements
Changelog
🆑