Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Ninja Suit power cell upgrade fixes. #32902

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

BramvanZijp
Copy link
Contributor

@BramvanZijp BramvanZijp commented Oct 19, 2024

About the PR

This PR makes the following bugfixes/changes to the space ninja suit:

  1. When checking if the new cell is better compared to the current one, the self recharge rate (if any) of both cells is now considered.
  2. If a cell change attempt fails due to it not being a better cell, the player actually gets a popup instead of no indication as to why the change got cancelled.
  3. Power Cages (the ones used in the large ship mounted lasers) or any other item that is bigger then Normal no longer fit in the suit.

Why / Balance

  1. Because self recharging cells are objectively better for a ninja compared to ones that run out slower.
  2. Because the player should know why they cannot swap the cell, especially since it briefly shows as working on the client side before it gets reverted.
  3. Because why the fuck was this ever possible

Technical details

Both cells are now given a score, which is equal to their max capacity. If the cells can self recharge, the score is boosted by the recharge rage * 100, which still makes a microreactor score higher then a hyper capacity cell.

Media

Not neccesary.

Requirements

Changelog
🆑 BramvanZijp

  • add: The Space Ninja Suit will now give an error popup if you are trying to install a cell that is not better compared to the current cell.
  • tweak: When comparing which power cell is better when trying to swap them, the Space Ninja's Suit will now also consider if the power cells have self-recharge capability.
  • fix: You can no longer fit weapons-grade power cages into the space ninja suit.

@chromiumboy chromiumboy self-assigned this Oct 21, 2024
@chromiumboy chromiumboy added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Oct 21, 2024
@BramvanZijp
Copy link
Contributor Author

Requested changes have been applied.

Content.Server/Ninja/Systems/NinjaSuitSystem.cs Outdated Show resolved Hide resolved
Content.Server/Ninja/Systems/NinjaSuitSystem.cs Outdated Show resolved Hide resolved
Content.Server/Ninja/Systems/NinjaSuitSystem.cs Outdated Show resolved Hide resolved
Content.Server/Ninja/Systems/NinjaSuitSystem.cs Outdated Show resolved Hide resolved
@chromiumboy
Copy link
Contributor

Be sure to double-check that your formatting and naming conform to our conventions

@BramvanZijp
Copy link
Contributor Author

Changes applied, SHOULD be good to go now when checks finish.

@chromiumboy chromiumboy added PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. PR: Bug Fix Fixes a clear bug, no refactoring or features and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 22, 2024
@chromiumboy
Copy link
Contributor

Seems to be working fine, thanks for the fix

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Oct 22, 2024
@metalgearsloth metalgearsloth enabled auto-merge (squash) October 22, 2024 23:36
@metalgearsloth metalgearsloth merged commit ee8dede into space-wizards:master Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. PR: Bug Fix Fixes a clear bug, no refactoring or features Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants