-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several Ninja Suit power cell upgrade fixes. #32902
Merged
metalgearsloth
merged 8 commits into
space-wizards:master
from
BramvanZijp:NinjaReactor
Oct 22, 2024
Merged
Several Ninja Suit power cell upgrade fixes. #32902
metalgearsloth
merged 8 commits into
space-wizards:master
from
BramvanZijp:NinjaReactor
Oct 22, 2024
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromiumboy
reviewed
Oct 21, 2024
chromiumboy
added
the
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
label
Oct 21, 2024
Requested changes have been applied. |
chromiumboy
previously requested changes
Oct 21, 2024
Be sure to double-check that your formatting and naming conform to our conventions |
deltanedas
reviewed
Oct 21, 2024
Changes applied, SHOULD be good to go now when checks finish. |
chromiumboy
added
PR: Approved
Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
PR: Bug Fix
Fixes a clear bug, no refactoring or features
and removed
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
labels
Oct 22, 2024
Seems to be working fine, thanks for the fix |
github-actions
bot
added
the
Status: Needs Review
This PR requires new reviews before it can be merged.
label
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Approved
Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
PR: Bug Fix
Fixes a clear bug, no refactoring or features
Status: Needs Review
This PR requires new reviews before it can be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR makes the following bugfixes/changes to the space ninja suit:
Why / Balance
Technical details
Both cells are now given a score, which is equal to their max capacity. If the cells can self recharge, the score is boosted by the recharge rage * 100, which still makes a microreactor score higher then a hyper capacity cell.
Media
Not neccesary.
Requirements
Changelog
🆑 BramvanZijp