Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds beanies to the WinterDrobe! #32946

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

UBlueberry
Copy link
Contributor

@UBlueberry UBlueberry commented Oct 22, 2024

About the PR

Adds four red-and-white beanies to the winterdrobe, as well as room for more color combinations in the future.

Why / Balance

old:
I know the vendors are supposed to be frozen until uniform dying exists, but it's really really just an absolute shame I can't get my Space Canadian on. The original plan was multiple beanies of multiple color varieties, but I think a simple red-and-white beanie adds the charm that I and any other Space Canadians are looking for. It's also a very versatile color choice, compared to something like blue or green.

new:
Initially, I was aware of the freeze but didn't fully get why. The original plan was that I would sprite and code only one beanie - red and white. The scope shifted to making the sprite grayscale and changing the hex codes to get the colors I want, however I'm trying to avoid bloat to the vending machines (until uniform dying or whatever it is gets finished up) with the hopes that this PR has a higher chance of being merged now and I can figure out other colors later.

Is there a chance that something changes and the framework becomes redundant? Yes. Yes there is.

Media

image

Requirements

Changelog

🆑

  • add: Beanies can now be found in WinterDrobes, don'tchaknow.

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

RSI Diff Bot; head commit 97c2e04 merging into 3b0d8e6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/beanie.rsi

State Old New Status
body-equipped-HELMET Added
body-icon Added
body-inhand-left Added
body-inhand-right Added
cuffcrown-equipped-HELMET Added
cuffcrown-icon Added
cuffcrown-inhand-left Added
cuffcrown-inhand-right Added
pompom-equipped-HELMET Added
pompom-icon Added
pompom-inhand-left Added
pompom-inhand-right Added

Edit: diff updated after 97c2e04

@lzk228
Copy link
Contributor

lzk228 commented Oct 22, 2024

better to make it greyscale, so it can be dyed via prototypes in future

@UBlueberry
Copy link
Contributor Author

UBlueberry commented Oct 22, 2024

better to make it greyscale, so it can be dyed via prototypes in future

I know what you're talking about, but I just don't understand how I would go about that
And since "the future" might be weeks from now, I'd like at least this beanie in the game for now. Please thank you. :)

@beck-thompson
Copy link
Contributor

I know what you're talking about, but I just don't understand how I would go about that
And since "the future" might be weeks from now, I'd like at least this beanie in the game for now. Please thank you. :)

Its really easy you just need to make the layer that is colored grayscale, and then set the color in ymal

@UBlueberry
Copy link
Contributor Author

I know what you're talking about, but I just don't understand how I would go about that
And since "the future" might be weeks from now, I'd like at least this beanie in the game for now. Please thank you. :)

Its really easy you just need to make the layer that is colored grayscale, and then set the color in ymal

Would that work? Some pixels are already grayscale, right? Won't the white part of the beanie get colored too?

@UBlueberry UBlueberry marked this pull request as draft October 22, 2024 21:49
@UBlueberry
Copy link
Contributor Author

I know what I have to do now, just gotta do it

@UBlueberry UBlueberry marked this pull request as ready for review October 23, 2024 01:35
@UBlueberry
Copy link
Contributor Author

I think there's a "check failed for unrelated reasons" virus spreading around...
cough cough
6 feet away please.

@slarticodefast
Copy link
Member

Unrelated test fail, I'm rerunning it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants