Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Reviewers:" for spr land #188

Open
MaskRay opened this issue Mar 1, 2024 · 2 comments
Open

Remove "Reviewers:" for spr land #188

MaskRay opened this issue Mar 1, 2024 · 2 comments

Comments

@MaskRay
Copy link

MaskRay commented Mar 1, 2024

My typical workflow: compose a patch, run spr diff to create a PT, add reviewers on GitHub, get approved.
When I run spr land, the landed commit will include both Reviewers: and Reviewed By:. Reviewed By: is useful, but I want to hide Reviewers:.

When we were using Phabricator for llvm-project code review, the community consensus was that these tags array("Subscribers", "Reviewers", "Tags") are not useful. So there was a local patch to filter out them MaskRay/phabricator@5d531bc

@arichardson
Copy link

I just started using spr for LLVM development and also noticed the extra Reviewers: field. I agree that it's not useful and would like to see an option to omit it.

@arichardson
Copy link

I just had a look at the forks of this repository and it seems like master...bogner:spr:succint-messages does almost what I'd like to see (but I'd actually like to keep Reviewed by).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants