You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My typical workflow: compose a patch, run spr diff to create a PT, add reviewers on GitHub, get approved.
When I run spr land, the landed commit will include both Reviewers: and Reviewed By:. Reviewed By: is useful, but I want to hide Reviewers:.
When we were using Phabricator for llvm-project code review, the community consensus was that these tags array("Subscribers", "Reviewers", "Tags") are not useful. So there was a local patch to filter out them MaskRay/phabricator@5d531bc
The text was updated successfully, but these errors were encountered:
I just started using spr for LLVM development and also noticed the extra Reviewers: field. I agree that it's not useful and would like to see an option to omit it.
I just had a look at the forks of this repository and it seems like master...bogner:spr:succint-messages does almost what I'd like to see (but I'd actually like to keep Reviewed by).
My typical workflow: compose a patch, run
spr diff
to create a PT, add reviewers on GitHub, get approved.When I run
spr land
, the landed commit will include bothReviewers:
andReviewed By:
.Reviewed By:
is useful, but I want to hideReviewers:
.When we were using Phabricator for llvm-project code review, the community consensus was that these tags
array("Subscribers", "Reviewers", "Tags")
are not useful. So there was a local patch to filter out them MaskRay/phabricator@5d531bcThe text was updated successfully, but these errors were encountered: