-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update poet #6096
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proof because of reaching deadline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6096 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 301 301
Lines 32260 32260
=========================================
- Hits 26328 26326 -2
- Misses 4214 4216 +2
Partials 1718 1718 ☔ View full report in Codecov by Sentry. |
acud
approved these changes
Jul 4, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## Motivation The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
Build failed: |
poszu
approved these changes
Jul 4, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## Motivation The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## Motivation The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
Pull request successfully merged into develop. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new poet package has the
GenerateProof
function updated to not return an invalid proof because of a too short deadline.Description
The returned proof will always be valid, if the deadline is too short the
GenerateProof
method will continue to run until at leastsecurityParam
leaves have been generated, therefore always generating a valid proof.If the deadline should be a hard cut, the caller can use the context instead to end the
GenerateProof
method early.Test Plan
TODO