Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update poet #6096

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Update poet #6096

wants to merge 2 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 3, 2024

Motivation

The new poet package has the GenerateProof function updated to not return an invalid proof because of a too short deadline.

Description

The returned proof will always be valid, if the deadline is too short the GenerateProof method will continue to run until at least securityParam leaves have been generated, therefore always generating a valid proof.

If the deadline should be a hard cut, the caller can use the context instead to end the GenerateProof method early.

Test Plan

  • existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (9a01a6c) to head (0ff6721).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6096     +/-   ##
=========================================
- Coverage     81.6%   81.6%   -0.1%     
=========================================
  Files          301     301             
  Lines        32260   32260             
=========================================
- Hits         26328   26326      -2     
- Misses        4214    4216      +2     
  Partials      1718    1718             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acud acud self-requested a review July 4, 2024 00:57
@fasmat
Copy link
Member Author

fasmat commented Jul 4, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024
## Motivation

The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jul 4, 2024

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Jul 4, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024
## Motivation

The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jul 4, 2024

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024
## Motivation

The new poet package has the `GenerateProof` function updated to not return an invalid proof because of a too short deadline.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jul 4, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Update poet [Merged by Bors] - Update poet Jul 4, 2024
@spacemesh-bors spacemesh-bors bot closed this Jul 4, 2024
@spacemesh-bors spacemesh-bors bot deleted the update-poet branch July 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants