WiP: Add invalid prev ATX proof #6310
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6310 +/- ##
=========================================
- Coverage 81.7% 81.6% -0.2%
=========================================
Files 312 313 +1
Lines 34637 34752 +115
=========================================
+ Hits 28327 28376 +49
- Misses 4479 4528 +49
- Partials 1831 1848 +17 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
add-invalid-prev-atx-proof
branch
2 times, most recently
from
a968426
to
de6c8a8
Compare
fasmat
force-pushed
the
add-invalid-prev-atx-proof
branch
from
de6c8a8
to
cb6b5e7
Compare
spacemesh-bors
bot
changed the base branch from
no-wire-dependency
to
develop
fasmat
force-pushed
the
add-invalid-prev-atx-proof
branch
from
cb6b5e7
to
1e3eaf0
Compare
fasmat
force-pushed
the
add-invalid-prev-atx-proof
branch
from
1e3eaf0
to
5bb525e
Compare
poszu
requested changes
Sep 23, 2024
| @@ -1813,64 +1810,6 @@ func Test_MarryingMalicious(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestContextualValidation_DoublePost(t *testing.T) { | |||
There was a problem hiding this comment.
How about keeping the test to make sure this kind of malfeasance is detected?
Comment on lines
+25
to
+27
| // 4. Both marriage certificates have valid signatures. | ||
| // | ||
| // HINT: this works if the identity that publishes the marriage ATX marries themselves. |
There was a problem hiding this comment.
I think it's needed and enough to prove that the signers of the two ATXs are married.
Suggested change
| // 4. Both marriage certificates have valid signatures. | |
| // | |
| // HINT: this works if the identity that publishes the marriage ATX marries themselves. | |
| // 4. Signers of bots ATXs are married |
Comment on lines
+18
to
+19
| // ProofInvalidPrevAtxV2 is a proof that two ATXs published by an identity reference the same previous ATX for an | ||
| // identity. |
There was a problem hiding this comment.
Suggested change
| // ProofInvalidPrevAtxV2 is a proof that two ATXs published by an identity reference the same previous ATX for an | |
| // identity. | |
| // ProofInvalidPrevAtxV2 is a proof that two distinct ATXs reference the same previous ATX for one | |
| // of the included identities. |
| PreviousATXsRoot: types.Hash32(atx.PreviousATXs.Root()), | ||
| PreviousATXsRootProof: prevATXsRootProof, | ||
|
|
||
| PrevATXIndex: marriageIndex, |
There was a problem hiding this comment.
The previous ATX and marriage indexes mean different things and they are not usually equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6309
Description
In the
sql/identitiespackageactivation/wireis imported which would cause a cyclic dependency when theidentitiespackage is used in theactivation/wirepackage. Since the only function that requiresactivation/wireisidentities. GetMalfeasanceProofand that function was used primarily in tests I deleted it and replaced its usage withidentities.LoadMalfeasanceBlob.identities.LoadMalfeasaneBlobalso had a bug where it would not returnsql.ErrNotFoundwhen an equivocation set is stored but that set hasn't been marked as malicious yet, instead it would return[]byte{}, nil- which would cause broadcasting of empty proofs.Test Plan
TODO