Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0 #6321

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0 #6321

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024 •
edited by poszu
Loading

Description

Bumps github.com/quic-go/quic-go from 0.46.0 to 0.47.0.

Release notes

Sourced from github.com/quic-go/quic-go's releases.

v0.47.0

New Features

This release adds support for HTTP/3 Trailers, for both the server and the client side (#4581, #4630, #4656, #4639). Trailers work exactly the same way as for HTTP/1.1 and HTTP/2.

A big thank you to @​sudorandom for contributing this feature!

Fixes

  • idle timeout calculation when the peer sends a max_idle_timeout of 0 (or omits the transport parameter): #4666
  • fix handling of corrupted coalesced 1-RTT packets: #4663
  • qpack: don't reject literal field lines with name references if N bit is set to 1: quic-go/qpack#52
  • http3: correctly set the http.Response.ContentLength on responses that don't set the Content-Length header: #4645
  • http3: reject connection-specific header fields (Connection, Keep-Alive, Proxy-Connection, Transfer-Encoding, Upgrade and TE != "trailers"): #4646, #4655

Breaking Changes

  • quic.VersionNumber and logging.VersionNumber were removed: #4627

Heads-Up

@​sukunrt recently discovered and reported a race condition in the new time.Timer stopping logic introduced in Go 1.23. This manifests as a connection deadlock in quic-go. See #4659 and golang/go#69312 for more details. The new behavior is enabled when compiling with Go 1.23.x, and when the Go version in go.mod is set to Go 1.23.x.

Until this issue is fixed, it is recommended to either use Go 1.22.x, or to use GODEBUG="asynctimerchan=1" when compiling quic-go.

Changelog

New Contributors

... (truncated)

Commits
  • 8fc04bf fix calculation of idle timeout when the peer sets max_idle_timeout to 0 (#4666)
  • 1ad36eb http3: avoid re-parsing of the Content-Length header for responses (#4648)
  • b92bf0c http3: initialize trailer map with empty trailer entries when parsing the hea...
  • 4f48b2c update qpack to v0.5.1 (#4664)
  • 9478a67 ci: control concurrency of the interop Docker image builder (#4665)
  • 09c2ac8 http3: add HTTP Trailer support for servers (#4630)
  • ad8f3c0 fix handling of corrupted coalesced 1-RTT packets (#4663)
  • 4be70e0 protocol: use the packet number decoding / encoding logic from the RFC (#4661)
  • 135b8c0 interop: fix server setup for the HTTP/0.9 server (#4658)
  • 26a3525 http3: reject connection-specific header fields, check value of TE (#4655)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 9, 2024
@dependabot dependabot bot requested a review from dshulyak as a code owner September 9, 2024 01:20
@dependabot dependabot bot added the go Pull requests that update Go code label Sep 9, 2024
fasmat
fasmat requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/libp2p/go-libp2p 0.36.x is not compatible with github.com/quic-go/quic-go 0.47.0. So this is blocked until a new version of go-libp2p is available.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch 5 times, most recently from 524f6c4 to 327a0ea Compare September 13, 2024 10:25
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch from 327a0ea to dfa1fb9 Compare September 18, 2024 08:12
@fasmat fasmat force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch from 143eae0 to dfa1fb9 Compare September 23, 2024 10:51
@fasmat fasmat self-requested a review September 23, 2024 10:51
fasmat
fasmat requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-libp2p 0.36.3 has not fixed this issue yet.

@fasmat
Copy link
Member

fasmat commented Sep 23, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch from dfa1fb9 to 44137e0 Compare September 23, 2024 10:53
@dependabot
build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0
28f1a3d 
Bumps [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) from 0.46.0 to 0.47.0.
- [Release notes](https://github.com/quic-go/quic-go/releases)
- [Changelog](https://github.com/quic-go/quic-go/blob/master/Changelog.md)
- [Commits](quic-go/quic-go@v0.46.0...v0.47.0)

---
updated-dependencies:
- dependency-name: github.com/quic-go/quic-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch from 44137e0 to 28f1a3d Compare September 23, 2024 13:09
@fasmat
Copy link
Member

fasmat commented Sep 26, 2024

go-libp2p 0.36.4 is now compatible with quic-go 0.47.0

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (0e84c0a) to head (155ffa2).
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6321     +/-   ##
=========================================
- Coverage     81.8%   81.7%   -0.1%     
=========================================
  Files          312     312             
  Lines        34648   34657      +9     
=========================================
- Hits         28352   28343      -9     
- Misses        4464    4481     +17     
- Partials      1832    1833      +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member

fasmat commented Sep 27, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Sep 27, 2024
@spacemesh-bors
Try #6321:
cc8318c
@spacemesh-bors
Copy link

try

Build failed:

@fasmat
Copy link
Member

fasmat commented Sep 27, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Sep 27, 2024
@dependabot @fasmat
build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0 (#…
e7add8c 
…6321)

Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0 [Merged by Bors] - build(deps): Bump github.com/quic-go/quic-go from 0.46.0 to 0.47.0 Sep 27, 2024
@spacemesh-bors spacemesh-bors bot closed this Sep 27, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 27, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@spacemesh-bors spacemesh-bors bot deleted the dependabot/go_modules/github.com/quic-go/quic-go-0.47.0 branch September 27, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

@acud acud Awaiting requested review from acud acud is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fasmat