Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Bump post-rs to 0.7.12 #6323

Closed
wants to merge 3 commits into from
Closed

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 10, 2024

Motivation

Bump post-rs to the latest version 0.7.12

@poszu
Copy link
Contributor Author

poszu commented Sep 10, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Sep 10, 2024
## Motivation

Bump post-rs to the latest version [0.7.12](https://github.com/spacemeshos/post-rs/releases/tag/v0.7.12)
@spacemesh-bors
Copy link

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Sep 10, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Sep 10, 2024
## Motivation

Bump post-rs to the latest version [0.7.12](https://github.com/spacemeshos/post-rs/releases/tag/v0.7.12)
@spacemesh-bors
Copy link

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Sep 11, 2024

The Test_GenerateProof_TLS broke on Mac. The openssl and rustls were updated in post-rs, so possibly something changed there. In the test, the post-service cannot connect to the node:

[2024-09-11T09:44:07Z DEBUG rustls::client::tls13] Got CertificateRequest CertificateRequestPayloadTls13 { context: , extensions: [Unknown(UnknownExtension { typ: StatusRequest, payload:  }), Unknown(UnknownExtension { typ: SCT, payload:  }), SignatureAlgorithms([RSA_PSS_SHA256, ECDSA_NISTP256_SHA256, ED25519, RSA_PSS_SHA384, RSA_PSS_SHA512, RSA_PKCS1_SHA256, RSA_PKCS1_SHA384, RSA_PKCS1_SHA512, ECDSA_NISTP384_SHA384, ECDSA_NISTP521_SHA512, RSA_PKCS1_SHA1, ECDSA_SHA1_Legacy]), AuthorityNames([DistinguishedName(3062310b300906035504061302494c311230100603550408130953706163656d6573683111300f0603550407130854656c204176697631123010060355040a130953706163656d657368311830160603550403130f63612e73706163656d6573682e696f)])] }
[2024-09-11T09:44:07Z DEBUG rustls::client::common] Client auth requested but no cert/sigscheme available
[2024-09-11T09:44:07Z INFO  post_service::client] could not connect to the node: tonic::transport::Error(Transport, ConnectError(Custom { kind: InvalidData, error: InvalidCertificate(UnknownIssuer) }))

It seems that something is wrong with the certificates, but I'm not sure what.

@fasmat
Copy link
Member

fasmat commented Sep 13, 2024

The generated certificates appear to be valid (at least according to Keychain access). I also wasn't able to figure out what exactly doesn't work on mac. rusttls is available in version 0.23.13 and we are using 0.23.7, is it worth to try updating the dependency to see if that fixes the issue?

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (3053dca) to head (e4cda6c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6323   +/-   ##
=======================================
  Coverage     81.7%   81.7%           
=======================================
  Files          312     312           
  Lines        34637   34637           
=======================================
+ Hits         28321   28326    +5     
+ Misses        4483    4481    -2     
+ Partials      1833    1830    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu
Copy link
Contributor Author

poszu commented Sep 20, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Sep 20, 2024
## Motivation

Bump post-rs to the latest version [0.7.12](https://github.com/spacemeshos/post-rs/releases/tag/v0.7.12)
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Bump post-rs to 0.7.12 [Merged by Bors] - Bump post-rs to 0.7.12 Sep 20, 2024
@spacemesh-bors spacemesh-bors bot closed this Sep 20, 2024
@spacemesh-bors spacemesh-bors bot deleted the bump/post-rs-0.7.12 branch September 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants