-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - double-merge malfeasance proof #6339
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
changed the title
stub double-merge malfeasance proof
double-merge malfeasance proof
Sep 18, 2024
poszu
requested review from
dshulyak,
fasmat,
ivan4th and
acud
as code owners
September 19, 2024 12:18
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6339 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.1%
=========================================
Files 343 344 +1
Lines 44505 44613 +108
=========================================
+ Hits 35548 35632 +84
- Misses 6952 6972 +20
- Partials 2005 2009 +4 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
add-invalid-post-malfeasance
branch
from
November 6, 2024 11:45
6349b9b
to
cb7ccaa
Compare
…to atxmerge/double-merge-malfeasance-proof
…to atxmerge/double-merge-malfeasance-proof
…to atxmerge/double-merge-malfeasance-proof
fasmat
approved these changes
Nov 6, 2024
spacemesh-bors
bot
changed the base branch from
add-invalid-post-malfeasance
to
develop
November 6, 2024 22:24
…rge-malfeasance-proof
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
## Motivation Closes #6341 Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
double-merge malfeasance proof
[Merged by Bors] - double-merge malfeasance proof
Nov 6, 2024
spacemesh-bors
bot
deleted the
atxmerge/double-merge-malfeasance-proof
branch
November 6, 2024 23:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6341
Description
A malfeasance proof for when more than 1 merged ATX is published in a single epoch by a single equivocation set. Covers only the simple case when no checkpoint is involved. Support for checkpoint will come in following PRs
Test Plan
Added tests, skipped the test for when the first merged ATX is checkpointed - this should be IMO a syntactically invalid ATX.
TODO