[Merged by Bors] - chore: Remove unused environment variable in CI step #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th and
acud
as code owners
poszu
approved these changes
Sep 23, 2024
|
bors merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6343 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 312 312
Lines 34637 34637
=========================================
- Hits 28327 28324 -3
- Misses 4479 4480 +1
- Partials 1831 1833 +2 ☔ View full report in Codecov by Sentry. |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
## Motivation `codecov/codecov-action@v4` doesn't need the defined environment variable, it gains access to the token via the `token` argument passed to it.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
codecov/codecov-action@v4doesn't need the defined environment variable, it gains access to the token via thetokenargument passed to it.Description
Just removed the unneeded environment variable.
Test Plan
Existing tests pass
TODO