Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cors-everywhere on smeshing-service #6586

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jan 3, 2025

Enable the CORS-everywhere policy on the smeshing-service, which is using a proxy to talk with the JSON API on the node side.

Enable the CORS-everywhere policy on the smeshing-service, which is
using a proxy to talk with the JSON API on the node side.
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.0%. Comparing base (9196145) to head (a294344).
Report is 13 commits behind head on node-split-poc.

Files with missing lines Patch % Lines
api/proxy/proxy.go 12.5% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6586     +/-   ##
================================================
+ Coverage            76.8%   77.0%   +0.1%     
================================================
  Files                 346     346             
  Lines               46330   46373     +43     
================================================
+ Hits                35623   35718     +95     
+ Misses               8587    8524     -63     
- Partials             2120    2131     +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pigmej
Copy link
Member

pigmej commented Jan 3, 2025

It fixes part of the issue. Now some requests like:
http://localhost:19071/spacemesh.v2alpha1.NetworkService/Info gets duplicated CORS stuff. (applied twice)

That happens when both smesher-service and node-service have json-cors-everywhere specified

@poszu poszu merged commit 66ff8a2 into node-split-poc Jan 3, 2025
15 of 16 checks passed
@poszu poszu deleted the cors-on-activation-service branch January 3, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants