Fix check command: request for zst and add user agent to all requests
#43
brusherruci.yml
on: pull_request
Annotations
1 error and 9 warnings
|
Rustfmt
Process completed with exit code 1.
|
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L145
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:145:38
|
145 | let go_version = get_version(&go_path_str)?;
| ^^^^^^^^^^^^ help: change this to: `go_path_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
src/main.rs#L130
warning: unneeded `return` statement
--> src/main.rs:130:13
|
130 | return Ok::<i32, anyhow::Error>(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
130 - return Ok::<i32, anyhow::Error>(0);
130 + Ok::<i32, anyhow::Error>(0)
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L97
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:97:23
|
97 | match backup_file(&file_path) {
| ^^^^^^^^^^ help: change this to: `file_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/utils.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/utils.rs:84:23
|
84 | let url = build_url(&download_url, &path);
| ^^^^^^^^^^^^^ help: change this to: `download_url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
unneeded unit return type:
src/main.rs#L91
warning: unneeded unit return type
--> src/main.rs:91:39
|
91 | fn backup_or_fail(file_path: &PathBuf) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|
|
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|