Fix download #54
ci.yml
on: pull_request
Annotations
26 warnings
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L146
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:146:38
|
146 | let go_version = get_version(&go_path_str)?;
| ^^^^^^^^^^^^ help: change this to: `go_path_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
unneeded `return` statement:
src/main.rs#L131
warning: unneeded `return` statement
--> src/main.rs:131:13
|
131 | return Ok::<i32, anyhow::Error>(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
131 - return Ok::<i32, anyhow::Error>(0);
131 + Ok::<i32, anyhow::Error>(0)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L98
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:98:23
|
98 | match backup_file(&file_path) {
| ^^^^^^^^^^ help: change this to: `file_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
unneeded `return` statement:
src/utils.rs#L101
warning: unneeded `return` statement
--> src/utils.rs:101:5
|
101 | return number;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
101 - return number;
101 + number
|
|
unneeded `return` statement:
src/utils.rs#L99
warning: unneeded `return` statement
--> src/utils.rs:99:5
|
99 | return (number * mult).round() / mult;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
99 - return (number * mult).round() / mult;
99 + (number * mult).round() / mult
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/utils.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/utils.rs:84:23
|
84 | let url = build_url(&download_url, &path);
| ^^^^^^^^^^^^^ help: change this to: `download_url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
file opened with `create`, but `truncate` behavior not defined:
src/download.rs#L19
warning: file opened with `create`, but `truncate` behavior not defined
--> src/download.rs:19:6
|
19 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
|
unneeded unit return type:
src/main.rs#L92
warning: unneeded unit return type
--> src/main.rs:92:39
|
92 | fn backup_or_fail(file_path: &PathBuf) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L146
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:146:38
|
146 | let go_version = get_version(&go_path_str)?;
| ^^^^^^^^^^^^ help: change this to: `go_path_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
unneeded `return` statement:
src/main.rs#L131
warning: unneeded `return` statement
--> src/main.rs:131:13
|
131 | return Ok::<i32, anyhow::Error>(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
131 - return Ok::<i32, anyhow::Error>(0);
131 + Ok::<i32, anyhow::Error>(0)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L98
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:98:23
|
98 | match backup_file(&file_path) {
| ^^^^^^^^^^ help: change this to: `file_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
unneeded `return` statement:
src/utils.rs#L101
warning: unneeded `return` statement
--> src/utils.rs:101:5
|
101 | return number;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
101 - return number;
101 + number
|
|
unneeded `return` statement:
src/utils.rs#L99
warning: unneeded `return` statement
--> src/utils.rs:99:5
|
99 | return (number * mult).round() / mult;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
99 - return (number * mult).round() / mult;
99 + (number * mult).round() / mult
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/utils.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/utils.rs:84:23
|
84 | let url = build_url(&download_url, &path);
| ^^^^^^^^^^^^^ help: change this to: `download_url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
file opened with `create`, but `truncate` behavior not defined:
src/download.rs#L19
warning: file opened with `create`, but `truncate` behavior not defined
--> src/download.rs:19:6
|
19 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
|
unneeded unit return type:
src/main.rs#L92
warning: unneeded unit return type
--> src/main.rs:92:39
|
92 | fn backup_or_fail(file_path: &PathBuf) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|
Build library (self-hosted, macos, arm64, macos-arm64)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build library (macos-latest, macos)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build library (ubuntu-latest, linux)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build library (self-hosted, linux, arm64, linux-arm64)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build library (windows-2019, windows)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "quicksync-linux", "quicksync-linux-arm64", "quicksync-macos", "quicksync-macos-arm64", "quicksync-windows".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
quicksync-linux
Expired
|
13.9 MB |
|
quicksync-linux-arm64
Expired
|
14.2 MB |
|
quicksync-macos
Expired
|
9.05 MB |
|
quicksync-macos-arm64
Expired
|
8.47 MB |
|
quicksync-windows
Expired
|
7.4 MB |
|