Skip to content

Fix macos-amd64 build and get rid of useless suffix in CI #70

Fix macos-amd64 build and get rid of useless suffix in CI

Fix macos-amd64 build and get rid of useless suffix in CI #70

Triggered via pull request July 9, 2024 17:13
Status Success
Total duration 5m 51s
Billable time 2m
Artifacts 5

ci.yml

on: pull_request
Matrix: Build library
Publish release
0s
Publish release
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
Rustfmt
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L147
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:147:38 | 147 | let go_version = get_version(&go_path_str)?; | ^^^^^^^^^^^^ help: change this to: `go_path_str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
unneeded `return` statement: src/main.rs#L132
warning: unneeded `return` statement --> src/main.rs:132:13 | 132 | return Ok::<i32, anyhow::Error>(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 132 - return Ok::<i32, anyhow::Error>(0); 132 + Ok::<i32, anyhow::Error>(0) |
this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:99:23 | 99 | match backup_file(&file_path) { | ^^^^^^^^^^ help: change this to: `file_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/utils.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/utils.rs:84:23 | 84 | let url = build_url(&download_url, &path); | ^^^^^^^^^^^^^ help: change this to: `download_url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
file opened with `create`, but `truncate` behavior not defined: src/download.rs#L19
warning: file opened with `create`, but `truncate` behavior not defined --> src/download.rs:19:6 | 19 | .create(true) | ^^^^^^^^^^^^- help: add: `.truncate(true)` | = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` = help: alternatively, use `.append(true)` to append to the file instead of overwriting it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options = note: `#[warn(clippy::suspicious_open_options)]` on by default
unneeded unit return type: src/main.rs#L93
warning: unneeded unit return type --> src/main.rs:93:39 | 93 | fn backup_or_fail(file_path: &PathBuf) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build library (self-hosted, macos, arm64, macos-arm64)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build library (ubuntu-latest, linux)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build library (ubuntu-latest-arm-8-cores, linux-arm64)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build library (macos-latest, macos)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build library (windows-2019, windows)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "quicksync-linux", "quicksync-linux-arm64", "quicksync-macos", "quicksync-macos-arm64", "quicksync-windows". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
quicksync-linux Expired
13.9 MB
quicksync-linux-arm64 Expired
14.2 MB
quicksync-macos Expired
9.05 MB
quicksync-macos-arm64 Expired
8.49 MB
quicksync-windows Expired
7.4 MB