Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce unpacking prints spam #36

Merged
merged 1 commit into from
Aug 21, 2024
Merged

reduce unpacking prints spam #36

merged 1 commit into from
Aug 21, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Aug 21, 2024

Currently, it prints every 1MiB, which generates an endless wall of text (around 157000 lines for the current size of DB). This PR changes the print interval to every 1000 MiB.

@poszu poszu requested a review from brusherru August 21, 2024 12:51
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.03%. Comparing base (b4d937a) to head (39092a5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   48.03%   48.03%           
=======================================
  Files          11       11           
  Lines         254      254           
=======================================
  Hits          122      122           
  Misses        132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pigmej
Copy link
Member

pigmej commented Aug 21, 2024

I think 1000 is a bit too much (it's also used to show progress in smapp), can we make it 100MB ?

Copy link
Member

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brusherru
Copy link
Member

I think 1000 is a bit too much (it's also used to show progress in smapp), can we make it 100MB ?

I had the same doubts, but @poszu pointed me that it's about unpacking only :)
And probably it's enough even for HDD 🤔

@poszu poszu merged commit bb7ba81 into main Aug 21, 2024
17 checks passed
@poszu poszu deleted the fix/reduce-unpacking-spam branch August 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants