Do not follow redirect on checking layer in trusted db #4
clippy
6 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 6 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check warning on line 143 in src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:143:38
|
143 | let go_version = get_version(&go_path_str)?;
| ^^^^^^^^^^^^ help: change this to: `go_path_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 128 in src/main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/main.rs:128:13
|
128 | return Ok::<i32, anyhow::Error>(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
128 - return Ok::<i32, anyhow::Error>(0);
128 + Ok::<i32, anyhow::Error>(0)
|
Check warning on line 95 in src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:95:23
|
95 | match backup_file(&file_path) {
| ^^^^^^^^^^ help: change this to: `file_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 81 in src/utils.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/utils.rs:81:23
|
81 | let url = build_url(&download_url, &path);
| ^^^^^^^^^^^^^ help: change this to: `download_url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 23 in src/checksum.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/checksum.rs:23:42
|
23 | let md5_url = replace_sql_zip_with_md5(&url)?;
| ^^^^ help: change this to: `url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 89 in src/main.rs
github-actions / clippy
unneeded unit return type
warning: unneeded unit return type
--> src/main.rs:89:39
|
89 | fn backup_or_fail(file_path: &PathBuf) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default