Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quicksync version to the download urls #55

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

pigmej
Copy link
Member

@pigmej pigmej commented Oct 9, 2024

Added tool version to the quicksync URL to allow us later to configure behaviour based on it.

@pigmej pigmej requested a review from poszu October 9, 2024 11:08
src/partial_quicksync.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@poszu poszu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the tests, but otherwise LGTM

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.36%. Comparing base (6b66b32) to head (69f3f12).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   54.07%   54.36%   +0.29%     
==========================================
  Files          11       11              
  Lines         307      309       +2     
==========================================
+ Hits          166      168       +2     
  Misses        141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pigmej pigmej merged commit 33bdba8 into main Oct 9, 2024
17 checks passed
@pigmej pigmej deleted the version_in_url branch October 9, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants